Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Util funcs, updating func names, logs, configs and ensure service requirement #485

Merged
merged 10 commits into from
Jun 28, 2024

fix: simplify check

40c32d1
Select commit
Loading
Failed to load commit list.
Merged

feat: Add Util funcs, updating func names, logs, configs and ensure service requirement #485

fix: simplify check
40c32d1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 27, 2024 in 1s

61.02% (+0.09%) compared to 45e75aa

View this Pull Request on Codecov

61.02% (+0.09%) compared to 45e75aa

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.02%. Comparing base (45e75aa) to head (40c32d1).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/controllers/workspace_controller.go 0.00% 6 Missing ⚠️
pkg/inference/preset-inferences.go 0.00% 0 Missing and 1 partial ⚠️
pkg/tuning/preset-tuning.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   60.92%   61.02%   +0.09%     
==========================================
  Files          29       29              
  Lines        2559     2568       +9     
==========================================
+ Hits         1559     1567       +8     
- Misses        909      910       +1     
  Partials       91       91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov