Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of pkg/descheduler #5364

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR enhances the test coverage for the pkg/descheduler package by adding a new test file pkg/descheduler/core/helper_test.go and improving test coverage of all test files in pkg/descheduler.

Changes:

  1. Added new test file for pkg/descheduler/core/helper.go.
  2. Added meaningful test cases for functions which were not covered before by the tests and improved test coverage of pkg/descheduler/core/ from 13.75% to 85.5%.
  3. Added meaningful test cases for functions which were not covered before by the file descheduler_test.go, significantly improving its test coverage.

What type of PR is this?
/kind failing-test
/kind feature

What this PR does / why we need it:
Enhances the functionality of the pkg/descheduler package by improving the robustness of event handling and connection management.

Which issue(s) this PR fixes:
Fixes a part of #5235

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 13, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.28%. Comparing base (6e9136d) to head (810ca89).
Report is 30 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5364      +/-   ##
==========================================
+ Coverage   28.49%   29.28%   +0.78%     
==========================================
  Files         632      632              
  Lines       43856    43862       +6     
==========================================
+ Hits        12497    12844     +347     
+ Misses      30455    30089     -366     
- Partials      904      929      +25     
Flag Coverage Δ
unittests 29.28% <ø> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

/assign

@anujagrawal699
Copy link
Contributor Author

@XiShanYongYe-Chang CI Workflow?

@XiShanYongYe-Chang
Copy link
Member

/retest

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anujagrawal699
Good job!
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@karmada-bot karmada-bot merged commit bfa5839 into karmada-io:master Aug 14, 2024
12 checks passed
@XiShanYongYe-Chang
Copy link
Member

Sorry, my bad, I forgot to ask you to help squash the commits into one before merging the code.

@anujagrawal699
Copy link
Contributor Author

Sorry, my bad, I forgot to ask you to help squash the commits into one before merging the code.

I won't be able to squash it after merging? Also, i forgot to mention this PR increased test coverage of project by 0.79%.

@XiShanYongYe-Chang
Copy link
Member

Yes, it can't be compressed anymore after the merge.

@anujagrawal699
Copy link
Contributor Author

Yes, it can't be compressed anymore after the merge.

I'll keep that in mind from next PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants