Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Parser performance optimization #1711

Merged
merged 2 commits into from
Oct 24, 2024
Merged

perf: Parser performance optimization #1711

merged 2 commits into from
Oct 24, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 23, 2024

Parser performance optimization: remove duplicate dependency analysis

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

@Peefy
Copy link
Contributor

Peefy commented Oct 23, 2024

Good Job! LGTM!

Peefy
Peefy approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa He1pa changed the title perform: Parser performance optimization: perf: Parser performance optimization Oct 23, 2024
@He1pa He1pa marked this pull request as draft October 23, 2024 09:52
@coveralls
Copy link
Collaborator

coveralls commented Oct 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11481802946

Details

  • 53 of 54 (98.15%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 70.527%
Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/lib.rs 53 54 98.15%
Files with Coverage Reduction New Missed Lines %
kclvm/parser/src/lib.rs 1 96.15%
kclvm/tools/src/LSP/src/state.rs 12 81.14%
Totals Coverage Status
Change from base Build 11474942729: 0.02%
Covered Lines: 51749
Relevant Lines: 73375
💛 - Coveralls

@He1pa He1pa marked this pull request as ready for review October 24, 2024 02:27
@Peefy Peefy merged commit f8e6e86 into kcl-lang:main Oct 24, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peefy Peefy Peefy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@He1pa @Peefy @coveralls