Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for tracing for http addon #1021

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhussain91
Copy link

@bhussain91 bhussain91 commented May 9, 2024

Signed-off-by: Bilal Hussain [email protected]

Provide a description of what has been changed
The change is to add tracing capability into the keda http addon using opentelemetry. The changes allows the add on to generate and export spans to console (development) or otel gRPC endpoint. Further information on how to configure tracing can be found in the docs

Checklist

Fixes #

@bhussain91 bhussain91 requested a review from a team as a code owner May 9, 2024 12:00
@bhussain91 bhussain91 force-pushed the feature/keda-http-addon-tracing branch 2 times, most recently from f945b23 to 1eb19da Compare May 9, 2024 12:53
@bhussain91 bhussain91 force-pushed the feature/keda-http-addon-tracing branch from f64c6dc to 480050e Compare May 17, 2024 12:16
@bhussain91 bhussain91 force-pushed the feature/keda-http-addon-tracing branch 4 times, most recently from c95f18e to eb64c18 Compare May 23, 2024 15:52
interceptor/config/tracing.go Outdated Show resolved Hide resolved
interceptor/tracing/tracing.go Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

@bhussain91 any update on this please?

@bhussain91 bhussain91 force-pushed the feature/keda-http-addon-tracing branch from eb64c18 to b093281 Compare June 5, 2024 14:16
@bhussain91
Copy link
Author

bhussain91 commented Jun 6, 2024

@bhussain91 any update on this please?

@zroubalik I've refactored the code as per comments by @JorTurFer

docs/operate.md Outdated Show resolved Hide resolved
@bhussain91 bhussain91 force-pushed the feature/keda-http-addon-tracing branch 2 times, most recently from 8075523 to 91702b3 Compare June 6, 2024 14:21
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhussain91 could you please fix the linter problem?

@bhussain91 bhussain91 force-pushed the feature/keda-http-addon-tracing branch from 91702b3 to 444c2b5 Compare June 7, 2024 14:57
@bhussain91
Copy link
Author

@bhussain91 could you please fix the linter problem?

@zroubalik
added to exclude that line in linkinator
.github/workflows/linkinator.yaml

@bhussain91 bhussain91 force-pushed the feature/keda-http-addon-tracing branch from 444c2b5 to 4d127f0 Compare June 7, 2024 15:18
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhussain91 could you please fix conflicts in go.mod? 🙏

@bhussain91 bhussain91 force-pushed the feature/keda-http-addon-tracing branch from 4d127f0 to 1dc7d39 Compare June 11, 2024 09:48
@bhussain91
Copy link
Author

@zroubalik conflicts should be resolved now :) thanks

@bhussain91 bhussain91 force-pushed the feature/keda-http-addon-tracing branch from 1dc7d39 to cb53f12 Compare June 11, 2024 09:59
@bhussain91
Copy link
Author

@zroubalik @JorTurFer wondering why the e2e tests are failing here? whereas they seem to pass when I execute them locally. is there something I need to do?

@JorTurFer
Copy link
Member

The only test that's failing is interceptor_otel_tracing_test. Does it pass on your local?

@bhussain91
Copy link
Author

bhussain91 commented Jun 25, 2024

The only test that's failing is interceptor_otel_tracing_test. Does it pass on your local?

actually I've made some code changes, realised it was failing on my local again due to schema version conflict which should be resolved now, local e2e-tests are passing now on a brand new cluster with no test caches

@bhussain91 bhussain91 force-pushed the feature/keda-http-addon-tracing branch 2 times, most recently from dd98d3c to f23ed8f Compare June 25, 2024 14:51
@zroubalik
Copy link
Member

The only test that's failing is interceptor_otel_tracing_test. Does it pass on your local?

actually I've made some code changes, realised it was failing on my local again due to schema version conflict which should be resolved now, local e2e-tests are passing now on a brand new cluster with no test caches

great, there are some problems in the static check, PTAL

@bhussain91
Copy link
Author

bhussain91 commented Jun 26, 2024

The only test that's failing is interceptor_otel_tracing_test. Does it pass on your local?

actually I've made some code changes, realised it was failing on my local again due to schema version conflict which should be resolved now, local e2e-tests are passing now on a brand new cluster with no test caches

great, there are some problems in the static check, PTAL
@zroubalik I've fixed the static checks but I am not sure why the WhiteSource Security Check is failing. any ideas?

@zroubalik
Copy link
Member

@bhussain91 let's ingore the whitesource, it is failing across the whole org, not related to this PR

The only test that's failing is interceptor_otel_tracing_test. Does it pass on your local?

actually I've made some code changes, realised it was failing on my local again due to schema version conflict which should be resolved now, local e2e-tests are passing now on a brand new cluster with no test caches

great, there are some problems in the static check, PTAL
@zroubalik I've fixed the static checks but I am not sure why the WhiteSource Security Check is failing. any ideas?

It is an env issue, not related to this PR, please disregard.

@zroubalik zroubalik requested a review from wozniakjan July 1, 2024 09:04
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (sorry for the super late review, my life's been complicated). Could you rebase main branch to fix go.mod/go.sum issues?

Signed-off-by: Bilal Hussain <[email protected]>
@bhussain91 bhussain91 force-pushed the feature/keda-http-addon-tracing branch from f23ed8f to 4ad9caf Compare July 31, 2024 14:42
@bhussain91
Copy link
Author

LGTM! (sorry for the super late review, my life's been complicated). Could you rebase main branch to fix go.mod/go.sum issues?

Hey sorry was away on holiday, I've rebased now, should be all up to date

@JorTurFer
Copy link
Member

Sorry because we were on vacations this time :( could you rebase your branch again? Now we are here to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants