Upgrades dependencies #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieugagne
commented
Nov 5, 2021
| @@ -1,5 +1,6 @@ | |||
| require 'tty-table' | |||
| require 'pastel' | |||
| require 'unicode/display_width/string_ext' | |||
There was a problem hiding this comment.
Implement String#display_width for L#52 (https://github.com/keepcosmos/terjira/pull/108/files#diff-5d863c726df4ed831ad90eb8c126bba58564ecfb6d8ae5889ab0686f58e51edfR53)
mathieugagne
commented
Nov 5, 2021
Comment on lines
+27
to
+30
| spec.add_dependency "tty-table", ">= 0.12" | ||
| spec.add_dependency "tty-prompt", ">= 0.23" | ||
| spec.add_dependency "tty-spinner", ">= 0.9" | ||
| spec.add_dependency "strings", ">= 0.2" |
There was a problem hiding this comment.
Keeps these dependency a little more loose so it allows for easier upgrade next time around. Last merged PR was me, a year ago, for the same reason ;)
|
@keepcosmos Did you had time to look into this by any chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to have ruby 3.0 compatibility with my own gem using yours. These updates allowed me to upgrade
pasteland other gems properly.Tested manually that everything was still working as expected 👍