Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades dependencies #108

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Upgrades dependencies #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4544cad
Upgrades dependencies
mathieugagne Oct 27, 2021
22e7b89
Upgrades thor
mathieugagne Oct 27, 2021
9273abe
Adds unicode/display_width/string_ext for String#display_width method
mathieugagne Nov 5, 2021
d792665
Adds explicit requirement on strings gem
mathieugagne Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 48 additions & 52 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,96 +4,92 @@ PATH
terjira (0.4.8)
activesupport (>= 4)
jira-ruby (~> 2.1)
thor (~> 1.0.1)
tty-prompt (~> 0.20.0)
tty-spinner (~> 0.9.3)
tty-table (~> 0.11.0)
strings (>= 0.2)
thor (~> 1.0)
tty-prompt (>= 0.23)
tty-spinner (>= 0.9)
tty-table (>= 0.12)

GEM
remote: https://rubygems.org/
specs:
activesupport (6.0.3.4)
activesupport (6.1.4.1)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 0.7, < 2)
minitest (~> 5.1)
tzinfo (~> 1.1)
zeitwerk (~> 2.2, >= 2.2.2)
atlassian-jwt (0.2.0)
jwt (~> 2.1.0)
i18n (>= 1.6, < 2)
minitest (>= 5.1)
tzinfo (~> 2.0)
zeitwerk (~> 2.3)
atlassian-jwt (0.2.1)
jwt (~> 2.1)
coderay (1.1.3)
concurrent-ruby (1.1.7)
concurrent-ruby (1.1.9)
diff-lcs (1.4.4)
docile (1.3.2)
equatable (0.6.1)
i18n (1.8.5)
docile (1.4.0)
i18n (1.8.10)
concurrent-ruby (~> 1.0)
jira-ruby (2.1.3)
jira-ruby (2.1.5)
activesupport
atlassian-jwt
multipart-post
oauth (~> 0.5, >= 0.5.0)
jwt (2.1.0)
jwt (2.3.0)
method_source (0.9.2)
minitest (5.14.2)
minitest (5.14.4)
multipart-post (2.1.1)
necromancer (0.5.1)
oauth (0.5.4)
pastel (0.7.4)
equatable (~> 0.6)
oauth (0.5.6)
pastel (0.8.0)
tty-color (~> 0.5)
pry (0.12.2)
coderay (~> 1.1.0)
method_source (~> 0.9.0)
rake (13.0.1)
rake (13.0.6)
rspec (3.10.0)
rspec-core (~> 3.10.0)
rspec-expectations (~> 3.10.0)
rspec-mocks (~> 3.10.0)
rspec-core (3.10.0)
rspec-core (3.10.1)
rspec-support (~> 3.10.0)
rspec-expectations (3.10.0)
rspec-expectations (3.10.1)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.10.0)
rspec-mocks (3.10.0)
rspec-mocks (3.10.2)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.10.0)
rspec-support (3.10.0)
simplecov (0.19.1)
rspec-support (3.10.2)
simplecov (0.21.2)
docile (~> 1.1)
simplecov-html (~> 0.11)
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
strings (0.1.8)
strings-ansi (~> 0.1)
unicode-display_width (~> 1.5)
simplecov_json_formatter (0.1.3)
strings (0.2.1)
strings-ansi (~> 0.2)
unicode-display_width (>= 1.5, < 3.0)
unicode_utils (~> 1.4)
strings-ansi (0.2.0)
thor (1.0.1)
thread_safe (0.3.6)
tty-color (0.5.2)
thor (1.1.0)
tty-color (0.6.0)
tty-cursor (0.7.1)
tty-prompt (0.20.0)
necromancer (~> 0.5.0)
pastel (~> 0.7.0)
tty-reader (~> 0.7.0)
tty-reader (0.7.0)
tty-prompt (0.23.1)
pastel (~> 0.8)
tty-reader (~> 0.8)
tty-reader (0.9.0)
tty-cursor (~> 0.7)
tty-screen (~> 0.7)
wisper (~> 2.0.0)
tty-screen (0.7.1)
tty-screen (~> 0.8)
wisper (~> 2.0)
tty-screen (0.8.1)
tty-spinner (0.9.3)
tty-cursor (~> 0.7)
tty-table (0.11.0)
equatable (~> 0.6)
necromancer (~> 0.5)
pastel (~> 0.7.2)
strings (~> 0.1.5)
tty-screen (~> 0.7)
tzinfo (1.2.8)
thread_safe (~> 0.1)
unicode-display_width (1.7.0)
tty-table (0.12.0)
pastel (~> 0.8)
strings (~> 0.2.0)
tty-screen (~> 0.8)
tzinfo (2.0.4)
concurrent-ruby (~> 1.0)
unicode-display_width (2.1.0)
unicode_utils (1.4.0)
wisper (2.0.1)
zeitwerk (2.4.1)
zeitwerk (2.5.1)

PLATFORMS
ruby
Expand Down
1 change: 1 addition & 0 deletions lib/terjira/presenters/common_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
require 'tty-table'
require 'pastel'
require 'unicode/display_width/string_ext'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement String#display_width for L#52 (https://github.com/keepcosmos/terjira/pull/108/files#diff-5d863c726df4ed831ad90eb8c126bba58564ecfb6d8ae5889ab0686f58e51edfR53)


module Terjira
module CommonPresenter
Expand Down
9 changes: 5 additions & 4 deletions terjira.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,14 @@ Gem::Specification.new do |spec|
spec.executables = ["bin/jira"].map { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.add_dependency "thor", "~> 1.0.1"
spec.add_dependency "thor", "~> 1.0"
spec.add_dependency "jira-ruby", "~> 2.1"
spec.add_dependency "activesupport", ">= 4"

spec.add_dependency "tty-table", "~> 0.11.0"
spec.add_dependency "tty-prompt", "~> 0.20.0"
spec.add_dependency "tty-spinner", "~> 0.9.3"
spec.add_dependency "tty-table", ">= 0.12"
spec.add_dependency "tty-prompt", ">= 0.23"
spec.add_dependency "tty-spinner", ">= 0.9"
spec.add_dependency "strings", ">= 0.2"
Comment on lines +27 to +30
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeps these dependency a little more loose so it allows for easier upgrade next time around. Last merged PR was me, a year ago, for the same reason ;)


spec.add_development_dependency "bundler", "~> 2.1"
spec.add_development_dependency "rake", "~> 13.0"
Expand Down