-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Add sorting
key to metadata
#1184
Conversation
Signed-off-by: Christos Sidiropoulos <[email protected]>
sorting
key to metadatasorting
key to metadata
According to documentation sorting should be handled by the DataHandler without any need for manually setting values in the database. It should be sufficient to set |
Okay, thanks for checking the documentation. Thats really weird than |
Currently DataHandler is not used to insert metadata. I was writing about it here #1147 (comment) :
|
But that's by choice, not by design, isn't it? I don't see a reason not to revert to using the |
Oh, I just saw that you already suggested restoring the old method using the But yes, I think that's the way we should proceed! |
Ok, then I will revert it. |
@csidirop As I'm still working on It is necessary to add to
@sebastian-meyer Are you ok with this solution? |
Yes, that's fine! Thank you! |
Merging this as a temporary workaround (see #1209). |
See #1183
I added the missing entries in MetadataDefaults.php and added a call in
addMetadataAction()
so that it is saved in the metadata object.But it is not stored in the DB, where the value for the sorting key is still 0.
Any idea?