-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHNL-14775: Add badge incrementing logic to extension + README #244
Open
belleklaviyo
wants to merge
17
commits into
master
Choose a base branch
from
bl/badge_count_support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaysubra
reviewed
Dec 18, 2024
ajaysubra
reviewed
Dec 18, 2024
belleklaviyo
changed the title
CHNL-14775: Add badge incrementing logic to extension
CHNL-14775: Add badge incrementing logic to extension + README
Dec 18, 2024
5 tasks
ndurell
reviewed
Dec 18, 2024
ndurell
reviewed
Dec 18, 2024
ajaysubra
reviewed
Dec 19, 2024
README.md
Outdated
|
||
#### Handling Other Badging Sources | ||
|
||
Klaviyo SDK handles Klaviyo pushes, but if you have other sources that change the badge count, use the `KlaviyoSDK().setBadgeCount(:)` method wherever you change the badge count to keep in sync with SDK count. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we run this whole readme thru copilot to correct any grammatical issues/inconsistency in wording?
ab1470
reviewed
Dec 20, 2024
ab1470
reviewed
Dec 20, 2024
mark-piana
reviewed
Dec 20, 2024
mark-piana
reviewed
Dec 20, 2024
mark-piana
reviewed
Dec 20, 2024
mark-piana
reviewed
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SDK changes: CHNL-14775
README updates: CHNL-12941
Adding handling of new push payloads to service extension. Modifies the autoclearing set up, so it is on by default. Devs can disable it by adding a key in their Info.plist. README updated.
Check List
Manual Test Plan
Pre-reqs (new steps in README):
group.com.klaviyo.SDKTestApp.shared
)Klaviyo_App_Group
to both the main app target's and the extension's Info.plists with the name of the App GroupDefault Autoclearing
Disabling Autoclearing
disable_Klaviyo_badge_autoclearing
to the Info.plist of the main app target as a Boolean set toYES
(as defined in the README)Push Notification Console Testing
Send payloads as documented here to cover all possible paths of badge configurations:
Note: only other non happy paths worth testing imo are where we are sending the
badge_config
but nobadge_value
due to poor rendering and if there were some new enum case added on the backend and the SDK is not updated:End to End Testing
Supporting Materials