Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cali0707 as eventing reviewer #1428

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Added cali0707 as eventing reviewer #1428

merged 3 commits into from
Sep 11, 2023

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Sep 5, 2023

Changes

  • Add @Cali0707 as eventing reviewer
  • Create eventing-kafka-broker-reviewer role
  • Add @Cali0707 as eventing kafka broker reviewer

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2023
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2023
@Cali0707
Copy link
Member Author

Cali0707 commented Sep 5, 2023

/cc @pierDipi @matzew @creydr

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2023
@creydr
Copy link
Member

creydr commented Sep 5, 2023 

knative/community is out of date. Please run hack/update-codegen.sh

@pierDipi
Copy link
Member

pierDipi commented Sep 5, 2023

/lgtm
/cc @knative/technical-oversight-committee

@knative-prow knative-prow bot requested a review from a team September 5, 2023 13:49
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@Cali0707 Cali0707 mentioned this pull request Sep 5, 2023
Merged
pierDipi
pierDipi reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to create GH group like (in our case in knative-sandbox.yaml)

community/peribolos/knative.yaml

Lines 425 to 430 in 625ea8e

Eventing Reviewers:
description: Receive reviews for eventing related repositories
privacy: closed
members:
- aslom
- creydr

@pierDipi
Copy link
Member

pierDipi commented Sep 5, 2023

From there the hack/update-codegen.sh will generate owner aliases

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2023
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@knative-prow knative-prow bot merged commit b9e4826 into knative:main Sep 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@krsna-m krsna-m Awaiting requested review from krsna-m

@creydr creydr Awaiting requested review from creydr

@matzew matzew Awaiting requested review from matzew

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@dsimansk dsimansk

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cali0707 @creydr @pierDipi @dsimansk @knative-prow-robot