Add contour-tls to test matrix

[ReToCode]

Proposed Changes

• Add contour-tls to test matrix

/hold will need rebase after #15394

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ReToCode]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (2156812) to head (2664952).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15395      +/-   ##
==========================================
- Coverage   84.58%   84.57%   -0.01%     
==========================================
  Files         219      219              
  Lines       13587    13587              
==========================================
- Hits        11492    11491       -1     
- Misses       1726     1728       +2     
+ Partials      369      368       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ReToCode]

@dprotaso I initially tried to add contour in #15394 but there seems to be issues with contour + tls + domain mappings (see errors in this PR). Would you mind to check this? It may be that we did not catch this on the enable-tls PR as it just ran the prow TLS stuff.

[ReToCode]

FAIL test/conformance/api/v1beta1.TestDomainMapping (605.10s)
FAIL Package test/conformance/api/v1beta1 (10m5.175s)
FAIL test/conformance/api/v1.TestServiceWithTrafficSplit (1013.33s)

[knative-prow]

@ReToCode: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
istio-latest-no-mesh_serving_main	2664952	link	true	/test istio-latest-no-mesh

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dprotaso]

Yeah it's a known issue - knative-extensions/net-contour#862

Let me take a look at it

[dprotaso]

Curious how does kourier get around this problem?

[ReToCode]

Curious how does kourier get around this problem?

Hm good point, I think we "cheat" in that case: https://github.com/knative-extensions/net-kourier/blob/main/pkg/generator/ingress_translator.go#L216.

The connection from envoy to itself is actually not encrypted.

[dprotaso]

I'm going to close this out and revisit this when we have a fix in place