Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contour-tls to test matrix #15395

Closed
wants to merge 3 commits into from
Closed

Add contour-tls to test matrix #15395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc2b06f
Update TLS test matrix for istio and contour
ReToCode Jul 15, 2024
f1ee782
Remove contour-tls from test matrix
ReToCode Jul 15, 2024
2664952
Add contour-tls to test matrix
ReToCode Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/kind-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ jobs:
# Disabled due to flakiness: https://github.com/knative/serving/issues/14637
# - istio-ambient
- contour
- contour-tls
- gateway_istio
- gateway_contour

Expand All @@ -116,6 +117,11 @@ jobs:
- ingress: contour
namespace-resources: httpproxy

- ingress: contour-tls
ingress-class: contour
namespace-resources: httpproxy
enable-tls: 1

- ingress: istio
namespace-resources: virtualservices

Expand Down
10 changes: 6 additions & 4 deletions test/e2e-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,10 +389,12 @@ function install() {
fi

if (( ENABLE_TLS )); then
echo "Patch config-network to enable encryption features"
toggle_feature system-internal-tls enabled config-network

if [[ "$INGRESS_CLASS" == "kourier.ingress.networking.knative.dev" ]] || [[ "$INGRESS_CLASS" == "istio.ingress.networking.knative.dev" ]]; then
if [[ "$INGRESS_CLASS" == "kourier.ingress.networking.knative.dev" ]] || [[ "$INGRESS_CLASS" == "contour.ingress.networking.knative.dev" ]]; then
echo "Patch config-network to enable system-internal-tls feature (kourier/contour)"
toggle_feature system-internal-tls enabled config-network
fi
if [[ "$INGRESS_CLASS" == "kourier.ingress.networking.knative.dev" ]] || [[ "$INGRESS_CLASS" == "istio.ingress.networking.knative.dev" ]] || [[ "$INGRESS_CLASS" == "contour.ingress.networking.knative.dev" ]]; then
echo "Patch config-network to enable cluster-local-domain-tls feature (kourier/istio/contour)"
toggle_feature cluster-local-domain-tls enabled config-network
fi

Expand Down
Loading