Code refactoring: Remove RestService #5041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove logger.XForm `has_kpi_hook` field - Remove logger.Instance `posted_to_kpi` field - Remove openrosa.rest_service django app - Remove hook signal viewset
8 tasks
noliveleger
force-pushed
the
kobocat-django-app-part-2-remove-kobocat-rest-service
branch
from
c64c89f
to
2abd5ec
Compare
noliveleger
force-pushed
the
kobocat-django-app-part-2-remove-kobocat-rest-service
branch
from
2abd5ec
to
5943b24
Compare
noliveleger
force-pushed
the
kobocat-django-app-part-2-remove-kobocat-rest-service
branch
from
0f84555
to
c8996f4
Compare
jnm
changed the base branch from
kobocat-django-app-part-2
to
kobocat-django-app-part-2-remove-kobocat-backend
jnm
reviewed
Aug 22, 2024
kobo/apps/openrosa/apps/main/migrations/0015_drop_old_restservice_tables.py
Show resolved
Hide resolved
Base automatically changed from
kobocat-django-app-part-2-remove-kobocat-backend
to
kobocat-django-app-part-2
August 22, 2024 22:18
jnm
approved these changes
Aug 22, 2024
…-2-remove-kobocat-rest-service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ATTENTION RELEASE NOTES WRITER: the changes listed in kobotoolbox/docs#374 need to be called out in the release notes. —jnm
Part IV of #5036.
Remove Rest RestService openrosa sub app
(KPI) hooks are triggered directly when a submission comes in.
Notes
logger_xformandlogger_instance.Before KPI was sending a PATCH request to KoboCAT to make KoboCAT know about existence of an active Rest Service (thanks to
has_kpi_hook). When a submission came in, KoboCAT sent a request to/api/v2/hook-signalendpoint to let KPI know a new submission has been added.logger_instance.posted_to_kpiwas updated according to the success of the response of KPI endpoint. (but we never used it kobotoolbox/kobocat#580)All this back and worth is useless now since everything is under the same roof.
has_kpi_hookfieldposted_to_kpifieldImprovements:
Use
retry_backoffandautoretry_forinstead ofself.retryfor Celery task.Related issues
Related to #5036
kobotoolbox/kobocat#580 (to be closed when #5036 is merged)