fix(STONEINTG-751): don't auth when there is nothing to report #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have nothing to report, we should avoid to waste resources, mainly authentication to github API. Signed-off-by: Martin Basti <[email protected]>
MartinBasti
force-pushed
the
no-auth-for-nothing
branch
from
fcd3b5c to
ce6bb24
Compare
|
MartinBasti
requested review from
14rcole,
dirgim,
dheerajodha,
jsztuka and
kasemAlem
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
- Coverage 69.60% 69.44% -0.16%
==========================================
Files 44 44
Lines 4954 5018 +64
==========================================
+ Hits 3448 3485 +37
- Misses 1175 1204 +29
+ Partials 331 329 -2 ☔ View full report in Codecov by Sentry. |
kasemAlem
approved these changes
Jan 21, 2024
14rcole
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have nothing to report, we should avoid to waste resources, mainly authentication to github API.
Maintainers will complete the following section