[RFR] Update open() for a few classes #1217
Conversation
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
force-pushed
the
update_app_open_method
branch
from
4333297
to
3619ba3
Compare
nachandr
changed the title
|
Jenkins run before fix that shows that after() failed Jenkins run with fix that shows that after() passed |
cypress/utils/utils.ts
Outdated
| @@ -1373,8 +1373,8 @@ export function goToPage(page: number): void { | |||
| } | |||
|
|
|||
| export function selectUserPerspective(userType: string): void { | |||
| cy.get(commonView.optionMenu).click(); | |||
| cy.get(commonView.actionMenuItem).contains(userType).click(); | |||
| cy.get("button.pf-v5-c-menu-toggle.pf-m-full-width").click({ force: true }); | |||
There was a problem hiding this comment.
if the selector has changed ,let's make the change in the commonView.optionmenu.
This change will have to be tested for few more tests .
There was a problem hiding this comment.
Hi @sshveta , The selector hasn't changed . I'm using a different locator to get the job done because with the current locator, there are intermittent issues and the user perspective toggle doesn't always get clicked.
Sure, I could run the PR on additional tests .
There was a problem hiding this comment.
This PR tests the following -
- Creation and deletion of applications - 'Migration/Application inventory'
- Creation and deletion of stakeholders - 'Migration/Controls/Stakeholders'
- Creation and deletion of questionnaires - 'Migration/Administration/Assessment questionnaires'
|
This Jenkins job tests migration wave CRUD operations. Migration/Migration waves |
|
I will update the PR with the results of tier 0, tier 1 runs shortly . |
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
force-pushed
the
update_app_open_method
branch
3 times, most recently
from
34843a7
to
5ef98b5
Compare
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
force-pushed
the
update_app_open_method
branch
from
5ef98b5
to
6a39766
Compare
| selectItemsPerPage(itemsPerPage) | ||
| ); | ||
| cy.visit(Application.fullUrl, { timeout: 35 * SEC }).then((_) => { | ||
| cy.get("h1", { timeout: 100 * SEC }).should("contain", applicationInventory); |
There was a problem hiding this comment.
I think a timeout of 100 secods is too much.
I think if a page takes more than 35 secs (the current timeout we have for other tests) to load the test should fail because something is wrong there
There was a problem hiding this comment.
Yes, 100 seconds is too long for a page to load. I have reported a bug for that .
There was a problem hiding this comment.
we need to reduce the time and let this test fail .
It will impact overall time of execution.
There was a problem hiding this comment.
Lot of tests are using application page , let's reduce it to 5 Sec
|
Jenkins job
|
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
force-pushed
the
update_app_open_method
branch
from
3babc0a
to
cfe9225
Compare
| public static openList(forceReload = false): void { | ||
| if (forceReload) { | ||
| cy.visit(Stakeholders.fullUrl, { timeout: 35 * SEC }).then((_) => { | ||
| cy.get("h1", { timeout: 60 * SEC }).should("contain", "Controls"); |
There was a problem hiding this comment.
same here , let's reduce the time to 15 sec max
Signed-off-by: Nandini Chandra <[email protected]>
Resolves Jira MTA-3720
Jnekins run