Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Update open() for a few classes #1217

Merged
merged 9 commits into from
Sep 13, 2024
Merged

[RFR] Update open() for a few classes #1217

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3c78d62
Update open() for a few classes
nachandr Sep 5, 2024
71ef540
Update application.open()
nachandr Sep 5, 2024
c4ebaee
Update AssessmentQuestionnaire.open()
nachandr Sep 5, 2024
2416513
Update AssessmentQuestionnaire.deleteAllQuestionnaires()
nachandr Sep 6, 2024
3619ba3
Use different selector for user perspective menu toggle
nachandr Sep 6, 2024
4463b9d
Update open methods for a few classes
nachandr Sep 10, 2024
6a39766
Update Stakeholder URL
nachandr Sep 11, 2024
cfe9225
Address review comments
nachandr Sep 11, 2024
869eb46
Added comment about bug
nachandr Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cypress/e2e/models/administration/assessment_questionnaire/assessment_questionnaire.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
assessmentQuestionnaires,
deleteAction,
legacyPathfinder,
migration,
trTag,
} from "../../../types/constants";
import {
Expand Down Expand Up @@ -112,7 +113,7 @@ export class AssessmentQuestionnaire {
if (rowName == legacyPathfinder) {
continue;
}
cy.wrap($rows.eq(i).find(actionButton)).click();
cy.wrap($rows.eq(i).find(actionButton)).click({ force: true });
cy.get("li.pf-v5-c-menu__list-item")
.contains("Delete")
.then(($delete_btn) => {
Expand Down
7 changes: 4 additions & 3 deletions cypress/e2e/models/migration/applicationinventory/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,10 @@ export class Application {
public static open(forceReload = false): void {
const itemsPerPage = 100;
if (forceReload) {
cy.visit(Application.fullUrl, { timeout: 35 * SEC }).then((_) =>
selectItemsPerPage(itemsPerPage)
);
cy.visit(Application.fullUrl, { timeout: 35 * SEC }).then((_) => {
cy.get("h1", { timeout: 100 * SEC }).should("contain", applicationInventory);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a timeout of 100 secods is too much.

I think if a page takes more than 35 secs (the current timeout we have for other tests) to load the test should fail because something is wrong there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 100 seconds is too long for a page to load. I have reported a bug for that .

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to reduce the time and let this test fail .
It will impact overall time of execution.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot of tests are using application page , let's reduce it to 5 Sec

selectItemsPerPage(itemsPerPage);
});
return;
}

Expand Down
4 changes: 2 additions & 2 deletions cypress/utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1373,8 +1373,8 @@ export function goToPage(page: number): void {
}

export function selectUserPerspective(userType: string): void {
cy.get(commonView.optionMenu).click();
cy.get(commonView.actionMenuItem).contains(userType).click();
cy.get("button.pf-v5-c-menu-toggle.pf-m-full-width").click({ force: true });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the selector has changed ,let's make the change in the commonView.optionmenu.

This change will have to be tested for few more tests .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sshveta , The selector hasn't changed . I'm using a different locator to get the job done because with the current locator, there are intermittent issues and the user perspective toggle doesn't always get clicked.

Sure, I could run the PR on additional tests .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR tests the following -

  1. Creation and deletion of applications - 'Migration/Application inventory'
  2. Creation and deletion of stakeholders - 'Migration/Controls/Stakeholders'
  3. Creation and deletion of questionnaires - 'Migration/Administration/Assessment questionnaires'

cy.get(commonView.actionMenuItem).contains(userType).click({ force: true });
}

export function selectWithinModal(selector: string): void {
Expand Down
Loading