Refactor/add hal as datastructure #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1tram1
force-pushed
the
refactor/add-hal-as-datastructure
branch
from
d91ff9d
to
3388641
Compare
CohenArthur
reviewed
Jul 30, 2024
| log::debug!("aarch64_common_trap(0x{:x})", offset); | ||
|
|
||
| let int_type = match offset { | ||
| 0x000..=0x07f => InterruptType::SyncCurrentElSp0, |
There was a problem hiding this comment.
note that since Rustc 1.80 we can use exclusive range in patterns, so if it is easier this can be written as
Suggested change
| 0x000..=0x07f => InterruptType::SyncCurrentElSp0, | |
| 0x000..0x080 => InterruptType::SyncCurrentElSp0, |
don't know if the spec uses exclusive limits or not so feel free to ignore
n1tram1
force-pushed
the
refactor/add-hal-as-datastructure
branch
2 times, most recently
from
5616c9b
to
bd7612f
Compare
Taken from rust, very minor modifications on my side.
Skallwar
force-pushed
the
refactor/add-hal-as-datastructure
branch
3 times, most recently
from
77a70e7
to
120894e
Compare
Fixes: error[E0787]: the `asm!` macro is not allowed in naked functions Signed-off-by: Esteban Blanc <[email protected]>
Skallwar
force-pushed
the
refactor/add-hal-as-datastructure
branch
from
120894e
to
012f9aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.