Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syncmers at ends of reads #452

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add syncmers at ends of reads #452

wants to merge 4 commits into from

Conversation

marcelm
Copy link
Collaborator

@marcelm marcelm commented Oct 7, 2024

Split out from #426.

To Do

  • Maybe add these syncmers only when mcs is enabled
  • Fix tests

ksahlin and others added 4 commits October 7, 2024 15:30
Increases the number of seeds per read by 2*w_min seeds
Randstrobes that have no downstream partner at least w_min syncmers away get
their second hash set to 0, which means in the case of multi-context seeds
that the primary/main hash is also zero (because it is the smaller of the
two).

When this is done both for the reference and for queries, we get spurious
hits for all randstrobes towards the ends of queries (they get mapped to the
end of the reference).

Using the hash of the primary syncmer also as hash for the second syncmer
gets rid of the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants