Add GitHub Action for building and pushing UI and BFF images #446

Griffin-Sullivan · 2024-10-01T18:10:50Z

Description

Added a GH Action for building and pushing the UI and BFF images. Reuses the build script for Model Registry server, and edits the Makefile a little bit to get everything working. I also turned off image builds for MR server when a PR is being made only for UI / BFF changes. I can remove that if we want to keep building them.

How Has This Been Tested?

Going to test the PR as on: pull_request then if it passes will update the PR to run the action on: push.

Merge criteria:

All the commits have been signed-off (To pass the DCO check)

The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work.
Code changes follow the kubeflow contribution guidelines.

If you have UI changes

The developer has added tests or explained why testing cannot be added.
Included any necessary screenshots or gifs if it was a UI change.
Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Griffin-Sullivan · 2024-10-01T18:44:11Z

My user must not have access to the creds for the kubeflow docker so I'm assuming there's no way to test this without having the bot do it on push to main? @tarilabs any ideas how I can test?

tarilabs

My user must not have access to the creds for the kubeflow docker so I'm assuming there's no way to test this without having the bot do it on push to main? @tarilabs any ideas how I can test?

When I face similar situation @Griffin-Sullivan , I did setup DOCKERHUB_USERNAME etc in my GitHub repo (my fork) and updated IMG_ORG to point at my username in dockerhub.io

It also gives you an idea/survey of the changes we will need to apply midstream (kind request: please remind me/us when this PR will be synchronized midstream!)

edit: for a better "survey", I recommend also checking which changes are required for using quay.io instead of dockerhub: that is typically about setting one more env variable AND someIMG: in the GHA update.
This will be handy not only for midstreams but also when eventually we will publish to ghcr in addition to dockerhub for this upstream

tarilabs · 2024-10-02T12:56:13Z

.github/workflows/build-and-push-ui-images.yml

@@ -0,0 +1,94 @@
+name: Build and Push UI and BFF Images
+on:
+  pull_request:


I appreciate in the PR description is mentioned this on: pull_request is only for testing, but I'd rather make a comment so to make sure we don't forget before merging 😅

Griffin-Sullivan · 2024-10-02T17:54:32Z

You can see on https://github.com/Griffin-Sullivan/model-registry/actions/runs/11147635638/job/30982430523?pr=1 that the Action is passing when I push to my own quay repo. You can find them here: https://quay.io/user/gsulliva/?tab=repos

The reason the build-and-test-image action is failing is because I'm forcing the build script to run with quay.io so once that is removed when we are ready to merge it should pass fine.

alexcreasy · 2024-10-03T10:12:05Z

.github/workflows/build-and-push-ui-images.yml

+jobs:
+  build-image:
+    runs-on: ubuntu-latest
+    environment: griffin-testing # TODO: REMOVE LINE BEFORE MERGING


Just an extra reminder this line is here :D

alexcreasy · 2024-10-03T10:22:48Z

scripts/build_deploy.sh

@@ -3,7 +3,7 @@
 set -e

 # see Makefile for the IMG_ variables semantic
-IMG_REGISTRY=""
+IMG_REGISTRY="quay.io" # TODO: CHANGE TO EMPTY STRING BEFORE MERGE!!!


Another reminder :D

alexcreasy · 2024-10-03T10:25:24Z

Looks good, I haven't completely groked the logic but the general tasks all look good!

Griffin-Sullivan · 2024-10-04T15:00:12Z

Latest run is still passing on https://github.com/Griffin-Sullivan/model-registry/actions/runs/11162537114/job/31027401589?pr=1. If someone will review this I can remove all the TODOs 😄

tarilabs

I think it's worthy to remove the TODOs

/lgtm

tarilabs · 2024-10-05T09:56:07Z

.github/workflows/build-and-push-ui-images.yml

+        shell: bash
+        env:
+          IMG_REPO: ${{ env.IMG_UI_REPO }}
+          IMG: ${{ env.IMG_ORG }}/${{ env.IMG_UI_REPO }}


this IMG will need to be prefixed with quay.io for midstream, correct?

I'm thinking if we should just be explicit and introduce docker.io/ prefix in all GHAs 🤔
what is your team thought here?:

So I discussed with @lucferbux and @alexcreasy, and the current plan for midstream is to combine the UI here with the midstream image for the dashboard using webpack. That means we don't need a separate image for Model Registry UI and it will only be used for upstream.

ack! thanks for the update

Signed-off-by: Griffin-Sullivan <[email protected]>

tarilabs

/lgtm

ederign · 2024-10-08T12:55:50Z

@tarilabs we need you to merge this one!

alexcreasy

All looks good to me.

alexcreasy · 2024-10-08T12:59:03Z

@tarilabs would you mind approving this, if you're happy with the changes? It's outside my or Eder's jurisdiction :)

tarilabs

/approve

google-oss-prow · 2024-10-08T13:02:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy, ederign, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tarilabs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alexcreasy · 2024-10-08T13:03:01Z

thanks @tarilabs

Signed-off-by: Matteo Mortari <[email protected]>

google-oss-prow bot added the do-not-merge/work-in-progress label Oct 1, 2024

google-oss-prow bot requested review from andreyvelich, rareddy and zijianjoy October 1, 2024 18:10

github-actions bot added the Area/GitHub label Oct 1, 2024

google-oss-prow bot added the size/L label Oct 1, 2024

Griffin-Sullivan force-pushed the ui-images branch from a93f77d to 3e9902a Compare October 1, 2024 18:13

github-actions bot added the Area/UI label Oct 1, 2024

Griffin-Sullivan force-pushed the ui-images branch from 3e9902a to 0e98ea4 Compare October 1, 2024 18:36

tarilabs requested changes Oct 2, 2024

View reviewed changes

Griffin-Sullivan force-pushed the ui-images branch 4 times, most recently from c3bd640 to 03d0046 Compare October 2, 2024 16:17

Griffin-Sullivan had a problem deploying to griffin-testing October 2, 2024 16:18 — with GitHub Actions Failure

Griffin-Sullivan force-pushed the ui-images branch from 03d0046 to c5bceac Compare October 2, 2024 16:20

Griffin-Sullivan had a problem deploying to griffin-testing October 2, 2024 16:20 — with GitHub Actions Failure

Griffin-Sullivan marked this pull request as ready for review October 2, 2024 17:54

google-oss-prow bot removed the do-not-merge/work-in-progress label Oct 2, 2024

google-oss-prow bot requested a review from ederign October 2, 2024 17:55

alexcreasy reviewed Oct 3, 2024

View reviewed changes

Griffin-Sullivan force-pushed the ui-images branch from c5bceac to bcfe41b Compare October 3, 2024 13:04

google-oss-prow bot added size/M and removed size/L labels Oct 3, 2024

Griffin-Sullivan had a problem deploying to griffin-testing October 3, 2024 13:05 — with GitHub Actions Failure

tarilabs reviewed Oct 5, 2024

View reviewed changes

google-oss-prow bot assigned tarilabs Oct 5, 2024

google-oss-prow bot added the lgtm label Oct 5, 2024

Add GitHub Action for building and pushing UI and BFF images

ece639b

Signed-off-by: Griffin-Sullivan <[email protected]>

Griffin-Sullivan force-pushed the ui-images branch from bcfe41b to ece639b Compare October 7, 2024 14:43

google-oss-prow bot removed the lgtm label Oct 7, 2024

tarilabs reviewed Oct 7, 2024

View reviewed changes

google-oss-prow bot added the lgtm label Oct 7, 2024

ederign approved these changes Oct 8, 2024

View reviewed changes

alexcreasy approved these changes Oct 8, 2024

View reviewed changes

tarilabs approved these changes Oct 8, 2024

View reviewed changes

google-oss-prow bot added the approved label Oct 8, 2024

google-oss-prow bot merged commit 222194a into kubeflow:main Oct 8, 2024
16 checks passed

tarilabs added a commit to tarilabs/model-registry that referenced this pull request Oct 15, 2024

Adapt kubeflow#446 for midstream ODH

3c040ae

Signed-off-by: Matteo Mortari <[email protected]>

tarilabs mentioned this pull request Oct 15, 2024

periodic sync upstream KF to midstream ODH opendatahub-io/model-registry#134

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GitHub Action for building and pushing UI and BFF images #446

Add GitHub Action for building and pushing UI and BFF images #446

Griffin-Sullivan commented Oct 1, 2024 •

edited

Loading

Griffin-Sullivan commented Oct 1, 2024

tarilabs left a comment •

edited

Loading

tarilabs Oct 2, 2024

Griffin-Sullivan commented Oct 2, 2024

alexcreasy Oct 3, 2024

alexcreasy Oct 3, 2024

alexcreasy commented Oct 3, 2024

Griffin-Sullivan commented Oct 4, 2024

tarilabs left a comment

tarilabs Oct 5, 2024

Griffin-Sullivan Oct 7, 2024

tarilabs Oct 7, 2024

tarilabs left a comment

ederign commented Oct 8, 2024

alexcreasy left a comment

alexcreasy commented Oct 8, 2024

tarilabs left a comment

google-oss-prow bot commented Oct 8, 2024

alexcreasy commented Oct 8, 2024

Add GitHub Action for building and pushing UI and BFF images #446

Add GitHub Action for building and pushing UI and BFF images #446

Conversation

Griffin-Sullivan commented Oct 1, 2024 • edited Loading

Description

How Has This Been Tested?

Merge criteria:

Griffin-Sullivan commented Oct 1, 2024

tarilabs left a comment • edited Loading

Choose a reason for hiding this comment

tarilabs Oct 2, 2024

Choose a reason for hiding this comment

Griffin-Sullivan commented Oct 2, 2024

alexcreasy Oct 3, 2024

Choose a reason for hiding this comment

alexcreasy Oct 3, 2024

Choose a reason for hiding this comment

alexcreasy commented Oct 3, 2024

Griffin-Sullivan commented Oct 4, 2024

tarilabs left a comment

Choose a reason for hiding this comment

tarilabs Oct 5, 2024

Choose a reason for hiding this comment

Griffin-Sullivan Oct 7, 2024

Choose a reason for hiding this comment

tarilabs Oct 7, 2024

Choose a reason for hiding this comment

tarilabs left a comment

Choose a reason for hiding this comment

ederign commented Oct 8, 2024

alexcreasy left a comment

Choose a reason for hiding this comment

alexcreasy commented Oct 8, 2024

tarilabs left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Oct 8, 2024

alexcreasy commented Oct 8, 2024

Griffin-Sullivan commented Oct 1, 2024 •

edited

Loading

tarilabs left a comment •

edited

Loading