Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] testbench snapshot #59

Closed
wants to merge 8 commits into from

Conversation

tarilabs
Copy link
Member

Using this branch to snapshot a testbench showing tests are passing as expected

Description

This branch includes modifications from:

and an ad-hoc build of Kiota to test PR already sent upstream.

The testbench provide a demonstrator using Kiota to codegen Python client, and using the Python client to:

  • post/get RegisteredModel
  • and then, post/get ModelVersion for a RegisteredModel
  • and then, post/get ModelArtifact and DocArtifact for a RegisteredModel

Screenshot 2024-04-11 at 10 43 52

How Has This Been Tested?

make install
make test

in the test/python-kiota directory.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Marking this PR to "snapshot" the code and the test performed, since is not to be merged at this time, raising as Draft.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs tarilabs changed the title [draft [draft] testbench snapshot Apr 11, 2024
tarilabs pushed a commit to tarilabs/model-registry that referenced this pull request May 16, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tarilabs
Copy link
Member Author

With the MR python client rebase on REST (#152) this appears to no longer be needed, so we're going to close this.

For more information: #181
If you believe this was closed in error, feel free to reopen or submit a new record.

Thank you for contributions, we truly appreciated your commitment and everyone's direct and indirect work to rebase the MR python client on REST.

@tarilabs tarilabs closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants