Review use of nolint directives across code

[killianmuldoon]

CAPV uses many linters from golangci-lint, but many of these linters are skipped in some packages due to the use of nolint directives. The usage of these should be reviewed and as many as possible should be removed. This work should be tackled as a follow-on from #2058

Some initial findings:

• godot:
  • Should only be used in old APIVersions. Should be removed everywhere else.
    • 🌱 Remove lint ignore for comments and unhandled errors #2383
  • gosec: 8 usages. @Ankitasw
    • 🌱 Remove nolint for gosec #2406
• Allowed in test code.
  • staticcheck: 8 @xiujuanx
  • 🌱 Remove lint ignore for staticcheck #2427
  • nestif: 6 @adityabhatia
    • 🌱 remove //nolint:nestif directives #2410
  • gocritic: 3 @MrDXY
    • 🌱 Remove lint ignore for gocritic #2399
  • gocyclo: 2 @Ankitasw
    • 🌱 Remove nolint usages for gocyclo, paralleltest, wrapcheck and gocognit #2407
  • errcheck: 2 @Ankitasw
    • 🌱 Remove nolint usages for errcheck, revive, prealloc, goconst, ineffassign #2409
  • gocognit: 2 @Ankitasw
    • 🌱 Remove nolint usages for gocyclo, paralleltest, wrapcheck and gocognit #2407
  • revive: 2 @Ankitasw
    • 🌱 Remove nolint usages for errcheck, revive, prealloc, goconst, ineffassign #2409
  • parallelltest: 1 @Ankitasw
    • 🌱 Remove nolint usages for gocyclo, paralleltest, wrapcheck and gocognit #2407
  • wrapcheck: 1 @Ankitasw
    • 🌱 Remove nolint usages for gocyclo, paralleltest, wrapcheck and gocognit #2407
  • prealloc: 1 @Ankitasw
    • 🌱 Remove nolint usages for errcheck, revive, prealloc, goconst, ineffassign #2409
  • containedctx @zhanggbj
    • 🌱 lint: enable containedctx lint #2297
• related to Refactor CAPV controller context #2295
  • goconst: 1 @Ankitasw
    • 🌱 Remove nolint usages for errcheck, revive, prealloc, goconst, ineffassign #2409
  • ineffassign: 1 @Ankitasw
    • 🌱 Remove nolint usages for errcheck, revive, prealloc, goconst, ineffassign #2409

The above usages should be investigated and we should remove where possible. Where not possible we should add comments beside the lint ignore directives explaining why these linters are ignored.

[killianmuldoon]

/help

[k8s-ci-robot]

@killianmuldoon:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zhanggbj]

• containedctx 🌱 Remove context from capv customized controller context #2431
  I'll pick up this, will remove nolint during the refactoring work.

Also CC @MrDXY @xiujuanx，if you have some bandwidth :-)

[MrDXY]

I can take this task as I have done similar work previously. 😄

• gocritic

[xiujuanx]

I can pick this one:

• staticcheck: 8

[adityabhatia]

I can pickup nestif cases

[Ankitasw]

I can pick gosec

[Ankitasw]

Will pick gocyclo , paralleltest and gocognit
@killianmuldoon do we have to enable these linters, as right now these are disabled?

[Ankitasw]

@killianmuldoon Also I see other linters have only occurrences <=2, can we combine them in same PR? Since the changes wont be significant.

[Ankitasw]

Will pick rest of the linters:
errcheck: 2
revive: 2
prealloc: 1
goconst: 1
ineffassign: 1

[adityabhatia]

@killianmuldoon nestif was also disabled, so the nolint:nestif directives were unused.

[chrischdi]

#2399 seems to be the last open PR for this 🎉

[killianmuldoon]

Looks like we've ticked everything off the list here - thanks a lot for all the effort folks!