-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove nolint usages for gocyclo, paralleltest, wrapcheck and gocognit #2407
🌱 Remove nolint usages for gocyclo, paralleltest, wrapcheck and gocognit #2407
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2407 +/- ##
==========================================
+ Coverage 60.74% 60.82% +0.07%
==========================================
Files 164 164
Lines 9475 9475
==========================================
+ Hits 5756 5763 +7
+ Misses 3302 3296 -6
+ Partials 417 416 -1
☔ View full report in Codecov by Sentry. |
c188133
to
2abfaed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
/hold
In case someone else wants to take a look
LGTM label has been added. Git tree hash: f9eca696b6bd04aaa7822f2a67aafa74fb61f185
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm /hold cancel Thanks! |
What this PR does / why we need it:
Remove usage of following:
//nolint:gocyclo
//nolint:gocognit
//nolint:paralleltest
//nolint:wrapcheck
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #2384