Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove nolint usages for gocyclo, paralleltest, wrapcheck and gocognit #2407

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Sep 29, 2023

What this PR does / why we need it:
Remove usage of following:
//nolint:gocyclo
//nolint:gocognit
//nolint:paralleltest
//nolint:wrapcheck

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2384

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2023
@Ankitasw Ankitasw changed the title Remove nolint usages for gocyclo, paralleltest and gocognit 🌱 Remove nolint usages for gocyclo, paralleltest and gocognit Sep 29, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e77d02c) 60.74% compared to head (2abfaed) 60.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
+ Coverage   60.74%   60.82%   +0.07%     
==========================================
  Files         164      164              
  Lines        9475     9475              
==========================================
+ Hits         5756     5763       +7     
+ Misses       3302     3296       -6     
+ Partials      417      416       -1     
Files Coverage Δ
pkg/services/govmomi/util.go 9.24% <ø> (ø)
pkg/services/govmomi/vcenter/clone.go 55.01% <ø> (ø)
test/helpers/envtest.go 72.99% <ø> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

/hold
In case someone else wants to take a look

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f9eca696b6bd04aaa7822f2a67aafa74fb61f185

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2023
@Ankitasw Ankitasw changed the title 🌱 Remove nolint usages for gocyclo, paralleltest and gocognit 🌱 Remove nolint usages for gocyclo, paralleltest, wrapcheck and gocognit Sep 29, 2023
@chrischdi
Copy link
Member

/lgtm

/hold cancel

Thanks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit d22afe4 into kubernetes-sigs:main Sep 29, 2023
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 29, 2023
@Ankitasw Ankitasw deleted the remove-nolint-gocyclo branch September 29, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants