Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] 🐛 CI: Introduces the thumbprint value in CI yaml #1984

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #1860

/assign chrischdi

NONE

The value gets used to run the CI e2e tests. The value in the
vsphere-dev.yaml is a placeholder which needs to be updated when running
the tests locally.

Signed-off-by: Sagar Muchhal <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-test-release-1-6 005ef82 link true /test pull-cluster-api-provider-vsphere-test-release-1-6
pull-cluster-api-provider-vsphere-e2e-release-1-6 005ef82 link true /test pull-cluster-api-provider-vsphere-e2e-release-1-6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@randomvariable
Copy link
Member

needs a go mod tidy

@chrischdi
Copy link
Member

Nope, go mod tidy unfortunately does not help. But going down on this at #1983 :-)

@chrischdi
Copy link
Member

Note: this PR is required to fix CI which is red due to:

Failed to run clusterctl config cluster
Unexpected error:
    <*yamlprocessor.errMissingVariables | 0xc000ccc090>: {
        Missing: [
            "VSPHERE_TLS_THUMBPRINT",
        ],
    }
    value for variables [VSPHERE_TLS_THUMBPRINT] is not set. Please set the value using os environment variables or the clusterctl config file
occurred
/home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/clusterctl/client.go:216}

(which is visible after #1983 gets merged)

@randomvariable
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@chrischdi
Copy link
Member

closing in favor of #1983

@chrischdi
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@chrischdi: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants