🌱 Use shellcheck binary instead of self-built docker image

[chrischdi]

What this PR does / why we need it:

This PR:

• replaces the current shellcheck implementation (based on a self-built container image used via docker run) by the solution which is used at https://github.com/kubernetes-sigs/cluster-api.
• enables to run make lint-shell or make verify-shellcheck on arm based macs.
• this also adds the verify-shellcheck target for compatibility with CAPI's Makefile.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2125

/area ci

[k8s-ci-robot]

@chrischdi: The label(s) area/ci cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

This PR:

• replaces the current shellcheck implementation (based on a self-built container image used via docker run) by the solution which is used at https://github.com/kubernetes-sigs/cluster-api.
• enables to run make lint-shell or make verify-shellcheck on arm based macs.
• this also adds the verify-shellcheck target for compatibility with CAPI's Makefile.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2125

/area ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 331eb3fe5fc4f13e83bd28476e2bc7672225de8f

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/cherry-pick release-1.8

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/cherry-pick release-1.6

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/cherry-pick release-1.5

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #2220

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: #2211 failed to apply on top of branch "release-1.7":

Applying: Use shellcheck binary instead of self-built docker image
Using index info to reconstruct a base tree...
M	Makefile
Falling back to patching base and 3-way merge...
Removing hack/tools/shellcheck/Makefile
Removing hack/tools/shellcheck/Dockerfile
Removing hack/match-release-tag.sh
Removing hack/check-shell.sh
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use shellcheck binary instead of self-built docker image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: #2211 failed to apply on top of branch "release-1.6":

Applying: Use shellcheck binary instead of self-built docker image
Using index info to reconstruct a base tree...
M	Makefile
Falling back to patching base and 3-way merge...
Removing hack/tools/shellcheck/Makefile
Removing hack/tools/shellcheck/Dockerfile
Removing hack/match-release-tag.sh
Removing hack/check-shell.sh
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use shellcheck binary instead of self-built docker image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: #2211 failed to apply on top of branch "release-1.5":

Applying: Use shellcheck binary instead of self-built docker image
Using index info to reconstruct a base tree...
M	Makefile
Falling back to patching base and 3-way merge...
Removing hack/tools/shellcheck/Makefile
Removing hack/tools/shellcheck/Dockerfile
Removing hack/match-release-tag.sh
Removing hack/check-shell.sh
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use shellcheck binary instead of self-built docker image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chrischdi]

/hold

[sbueringer]

There's not much to hold at this point :)