🌱 Remove nolint usages for gocyclo, paralleltest, wrapcheck and gocognit

apis/v1alpha3/conversion_test.go

@@ -30,7 +30,6 @@ import (
 	infrav1 "sigs.k8s.io/cluster-api-provider-vsphere/apis/v1beta1"
 )
 
-//nolint:paralleltest
 func TestFuzzyConversion(t *testing.T) {
 	g := NewWithT(t)
 	scheme := runtime.NewScheme()

pkg/services/govmomi/util.go

@@ -391,11 +391,6 @@ func getMacAddresses(ctx *virtualMachineContext) ([]string, map[string]int, map[
 // waitForIPAddresses waits for all network devices that should be getting an
 // IP address to have an IP address. This is any network device that specifies a
 // network name and DHCP for v4 or v6 or one or more static IP addresses.
-// The gocyclo detector is disabled for this function as it is difficult to
-// rewrite much simpler due to the maps used to track state and the lambdas
-// that use the maps.
-//
-//nolint:gocyclo,gocognit
 func waitForIPAddresses(
 	ctx *virtualMachineContext,
 	macToDeviceIndex map[string]int,

pkg/services/govmomi/vcenter/clone.go

@@ -45,8 +45,6 @@ const (
 // Clone kicks off a clone operation on vCenter to create a new virtual machine. This function does not wait for
 // the virtual machine to be created on the vCenter, which can be resolved by waiting on the task reference stored
 // in VMContext.VSphereVM.Status.TaskRef.
-//
-//nolint:gocognit,gocyclo
 func Clone(ctx *context.VMContext, bootstrapData []byte, format bootstrapv1.Format) error {
 	ctx = &context.VMContext{
 		ControllerContext: ctx.ControllerContext,

test/helpers/envtest.go

@@ -14,8 +14,6 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-//nolint:wrapcheck
-
 // Package helpers contains helpers for creating a test environment.
 package helpers