-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 test: use GinkgoRecover in go subroutine of ownerreference test #2552
🐛 test: use GinkgoRecover in go subroutine of ownerreference test #2552
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2552 +/- ##
==========================================
- Coverage 63.83% 63.34% -0.50%
==========================================
Files 119 120 +1
Lines 8678 8599 -79
==========================================
- Hits 5540 5447 -93
- Misses 2718 2730 +12
- Partials 420 422 +2 ☔ View full report in Codecov by Sentry. |
Thx! Let's go with that for now. I'm not sure if we additionally want some sort of eventually or retry . Right now the test will fail if c.List fails once if I understand it correctly /lgtm |
LGTM label has been added. Git tree hash: 4f696b1796ae5f2b48156fed51de4de37fb5dfcc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yep, same thought. |
What this PR does / why we need it:
Properly uses
defer GinkgoRecover
in go routine.Error occured in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-vsphere/2550/pull-cluster-api-provider-vsphere-e2e-full-main/1734914800363769856
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #