Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 test: use GinkgoRecover in go subroutine of ownerreference test #2552

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Dec 13, 2023

What this PR does / why we need it:

Properly uses defer GinkgoRecover in go routine.

Error occured in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-vsphere/2550/pull-cluster-api-provider-vsphere-e2e-full-main/1734914800363769856

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (94356e1) 63.83% compared to head (de0989f) 63.34%.
Report is 9 commits behind head on main.

Files Patch % Lines
pkg/services/govmomi/util.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
- Coverage   63.83%   63.34%   -0.50%     
==========================================
  Files         119      120       +1     
  Lines        8678     8599      -79     
==========================================
- Hits         5540     5447      -93     
- Misses       2718     2730      +12     
- Partials      420      422       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbueringer
Copy link
Member

sbueringer commented Dec 14, 2023

Thx!

Let's go with that for now.

I'm not sure if we additionally want some sort of eventually or retry . Right now the test will fail if c.List fails once if I understand it correctly

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f696b1796ae5f2b48156fed51de4de37fb5dfcc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@chrischdi
Copy link
Member Author

Thx!

Let's go with that for now.

I'm not sure if we additionally want some sort of eventually or retry . Right now the test will fail if c.List fails once if I understand it correctly

/lgtm /approve

Yep, same thought.

@k8s-ci-robot k8s-ci-robot merged commit 919c03f into kubernetes-sigs:main Dec 14, 2023
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants