Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Improve patch helper error handling #2865

Merged
merged 1 commit into from
Apr 3, 2024

Improve patch helper error handling

8b9dad1
Select commit
Loading
Failed to load commit list.
Merged

🌱 Improve patch helper error handling #2865

Improve patch helper error handling
8b9dad1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 3, 2024 in 0s

63.95% (-0.03%) compared to 80d2f2a

View this Pull Request on Codecov

63.95% (-0.03%) compared to 80d2f2a

Details

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 63.95%. Comparing base (80d2f2a) to head (8b9dad1).
Report is 11 commits behind head on main.

Files Patch % Lines
controllers/vspheredeploymentzone_controller.go 0.00% 3 Missing ⚠️
pkg/services/govmomi/service.go 0.00% 2 Missing ⚠️
controllers/serviceaccount_controller.go 0.00% 1 Missing ⚠️
controllers/servicediscovery_controller.go 0.00% 1 Missing ⚠️
controllers/vmware/vspherecluster_reconciler.go 0.00% 1 Missing ⚠️
controllers/vspherecluster_reconciler.go 50.00% 1 Missing ⚠️
controllers/vsphereclusteridentity_controller.go 0.00% 1 Missing ⚠️
controllers/vspheremachine_controller.go 0.00% 1 Missing ⚠️
controllers/vspherevm_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2865      +/-   ##
==========================================
- Coverage   63.97%   63.95%   -0.03%     
==========================================
  Files         160      160              
  Lines        9375     9367       -8     
==========================================
- Hits         5998     5991       -7     
+ Misses       2917     2915       -2     
- Partials      460      461       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.