-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 test: migrate to vm-operator v1alpha2 #3032
🌱 test: migrate to vm-operator v1alpha2 #3032
Conversation
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
e5974ca
to
f87e160
Compare
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
f87e160
to
bda7076
Compare
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
bda7076
to
2654b13
Compare
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
2654b13
to
d060e0d
Compare
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
d060e0d
to
8ab8af8
Compare
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main |
PowerState: vmoprv1.VirtualMachinePoweredOn, | ||
BiosUUID: "foo", | ||
Network: &vmoprv1.VirtualMachineNetworkStatus{ | ||
// TODO(chrischdi): if not works, we also have to add an interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works
// TODO(chrischdi): if not works, we also have to add an interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good if @fabriziopandini can take a look ASAP once he's back
8ab8af8
to
d290519
Compare
/retest |
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main |
lgtm pending rebase |
/hold to not forget the rebase |
1604e84
to
1ee9955
Compare
1ee9955
to
846d942
Compare
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main |
/retest |
/lgtm /assign @fabriziopandini |
LGTM label has been added. Git tree hash: a1bd4e110f91dba1e2c3bc80a7887ce589f118c0
|
Nice to see things getting simpler in our VM Operator bridge! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #2118