Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add machine UpToDate condition to KCP #11389

Merged
merged 1 commit into from
Nov 8, 2024
Merged

✨ Add machine UpToDate condition to KCP #11389

merged 1 commit into from
Nov 8, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:
Rif #11105

/area kubeadmcontrolplane

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The label(s) area/kubeadmcontrolplane cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes:
Rif #11105

/area kubeadmcontrolplane

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Nov 6, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 6, 2024
@fabriziopandini fabriziopandini mentioned this pull request Nov 6, 2024
Open
98 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@fabriziopandini fabriziopandini added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Nov 7, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Nov 7, 2024
sbueringer
sbueringer reviewed Nov 7, 2024
View reviewed changes
api/v1beta1/machine_types.go Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/controller.go Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/controller.go Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/controller.go Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2024
@fabriziopandini fabriziopandini changed the title [WIP] ✨ Add machine UpToDate condition to KCP ✨ Add machine UpToDate condition to KCP Nov 7, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@fabriziopandini fabriziopandini force-pushed the add-machine-upToDate-condition-to-kcp branch from 9ea4714 to 3228fdc Compare November 7, 2024 19:33
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
sbueringer
sbueringer reviewed Nov 8, 2024
View reviewed changes
controlplane/kubeadm/internal/control_plane.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters_test.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters_test.go Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/control_plane_test.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/control_plane_test.go Outdated Show resolved Hide resolved
@fabriziopandini
Add machine UpToDate condition to KCP
7c8ba1d 
# Conflicts:
#	controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go
@fabriziopandini fabriziopandini force-pushed the add-machine-upToDate-condition-to-kcp branch from 3228fdc to 7c8ba1d Compare November 8, 2024 11:24
@sbueringer
Copy link
Member

/lgtm
/approve

/hold
if you want to squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a673147ceb797a61235a4cfb59f981db3f21f982

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0f319c6 into kubernetes-sigs:main Nov 8, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Nov 8, 2024
@fabriziopandini fabriziopandini deleted the add-machine-upToDate-condition-to-kcp branch November 13, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @k8s-ci-robot @sbueringer