🌱 Extend MS ScalingUp and Remediationg conditions to include preflight check errors #11390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
sbueringer
commented
Nov 7, 2024
internal/controllers/machineset/machineset_controller_status_test.go
Outdated
Show resolved
Hide resolved
sbueringer
force-pushed
the
pr-ms-preflight
branch
from
86b0fe6
to
c34dc99
Compare
|
/test pull-cluster-api-e2e-main |
98 tasks
check errors Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-ms-preflight
branch
from
c34dc99
to
db77824
Compare
sbueringer
changed the title
k8s-ci-robot
added
size/L
|
/test pull-cluster-api-e2e-main |
Signed-off-by: Stefan Büringer [email protected]
|
/test pull-cluster-api-e2e-main |
sbueringer
added
the
tide/merge-method-squash
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4f469fe879aa6aa91dc9e975db873bb0cd69021f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
phoban01
pushed a commit
to phoban01/cluster-api
that referenced
this pull request
Nov 13, 2024
…t check errors (kubernetes-sigs#11390) * Extend MS ScalingUp and Remediationg conditions to include preflight check errors Signed-off-by: Stefan Büringer [email protected] * Always set message on OwnerRemediated condition Signed-off-by: Stefan Büringer [email protected] --------- Signed-off-by: Stefan Büringer [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Signed-off-by: Stefan Büringer [email protected]fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11105