Add feature toggle for custom error pages /metrics

[ricardoapl]

What this PR does / why we need it:

Adds feature toggle to expose /metrics and /debug/vars endpoints from custom error pages default backend

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

Fixes #9152

How Has This Been Tested?

Tested manually on local machine by running the binary with different environment variable combinations such as

ERROR_FILES_PATH=./www ./app

curl --include 127.0.0.1:8080/
HTTP/1.1 404 Not Found
Content-Type: text/html
Date: Fri, 16 Feb 2024 11:29:18 GMT
Content-Length: 60

<span>The page you're looking for could not be found.</span>

curl --include 127.0.0.1:8080/metrics
HTTP/1.1 200 OK
Content-Type: text/plain; version=0.0.4; charset=utf-8
Date: Fri, 16 Feb 2024 11:30:10 GMT
Transfer-Encoding: chunked

# HELP default_http_backend_http_request_count_total Counter of HTTP requests made.
# TYPE default_http_backend_http_request_count_total counter
default_http_backend_http_request_count_total{proto="1.1"} 8
...

curl --include 127.0.0.1:8080/debug/vars
HTTP/1.1 200 OK
Content-Type: application/json; charset=utf-8
Date: Fri, 16 Feb 2024 11:31:25 GMT
Transfer-Encoding: chunked

{
"cmdline": ["./app"],
...

METRICS_PORT=8081 ERROR_FILES_PATH=./www ./app

curl --include 127.0.0.1:8080/
HTTP/1.1 404 Not Found
Content-Type: text/html
Date: Fri, 16 Feb 2024 11:33:09 GMT
Content-Length: 60

<span>The page you're looking for could not be found.</span>

curl --include 127.0.0.1:8080/metrics
HTTP/1.1 404 Not Found
Content-Type: text/html
Date: Fri, 16 Feb 2024 11:33:55 GMT
Content-Length: 60

<span>The page you're looking for could not be found.</span>

curl --include 127.0.0.1:8081/metrics
HTTP/1.1 200 OK
Content-Type: text/plain; version=0.0.4; charset=utf-8
Date: Fri, 16 Feb 2024 11:34:21 GMT
Transfer-Encoding: chunked

# HELP default_http_backend_http_request_count_total Counter of HTTP requests made.
# TYPE default_http_backend_http_request_count_total counter
...

IS_EXPORT_METRICS=false METRICS_PORT=8081 ERROR_FILES_PATH=./www ./app

curl --include 127.0.0.1:8080/        
HTTP/1.1 404 Not Found
Content-Type: text/html
Date: Fri, 16 Feb 2024 11:37:37 GMT
Content-Length: 60

<span>The page you're looking for could not be found.</span>

curl --include 127.0.0.1:8080/metrics
HTTP/1.1 404 Not Found
Content-Type: text/html
Date: Fri, 16 Feb 2024 11:37:49 GMT
Content-Length: 60

<span>The page you're looking for could not be found.

curl --include 127.0.0.1:8080/debug/vars
HTTP/1.1 404 Not Found
Content-Type: text/html
Date: Fri, 16 Feb 2024 11:40:47 GMT
Content-Length: 60

<span>The page you're looking for could not be found.</span>

curl --include 127.0.0.1:8081/metrics
curl: (7) Failed to connect to 127.0.0.1 port 8081 after 0 ms: Couldn't connect to server

curl --include 127.0.0.1:8081/debug/vars
curl: (7) Failed to connect to 127.0.0.1 port 8081 after 0 ms: Couldn't connect to server

IS_EXPORT_METRICS=false ERROR_FILES_PATH=./www ./app

curl --include 127.0.0.1:8080/       
HTTP/1.1 404 Not Found
Content-Type: text/html
Date: Fri, 16 Feb 2024 11:39:42 GMT
Content-Length: 60

<span>The page you're looking for could not be found.</span>

curl --include 127.0.0.1:8080/metrics
HTTP/1.1 404 Not Found
Content-Type: text/html
Date: Fri, 16 Feb 2024 11:39:59 GMT
Content-Length: 60

<span>The page you're looking for could not be found.</span>

curl --include 127.0.0.1:8080/debug/vars
HTTP/1.1 404 Not Found
Content-Type: text/html
Date: Fri, 16 Feb 2024 11:40:09 GMT
Content-Length: 60

<span>The page you're looking for could not be found.</span>

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	9781d2b
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/675ffcef58287b000851926d

[k8s-ci-robot]

Welcome @ricardoapl!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ricardoapl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ricardoapl]

This is still missing changes to the Helm chart, but I would really appreciate some feedback before the implementation is complete

[ricardoapl]

/assign @tao12345666333

[tao12345666333]

/ok-to-test

[ricardoapl]

@tao12345666333 @strongjz please take another look, I believe I have resolved all of the issues

[tao12345666333]

Thanks! I will have a test today.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricardoapl
Once this PR has been reviewed and has the lgtm label, please ask for approval from tao12345666333. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Gacko]

I basically like the idea, but it's changing a lot of stuff in places it shouldn't.

Please first make sure you rebased correctly as you're currently re-adding stuff we already removed some time ago.

[Gacko]

We have dropped s390x. I think you rebased your PR wrongly.

[ricardoapl]

Should be resolved with 9781d2b

[ricardoapl]

Thank you for taking the time to look at this @Gacko, I really appreciate it

I basically like the idea, but it's changing a lot of stuff in places it shouldn't.

Can you please share an example or two of where this is happening?

Please first make sure you rebased correctly as you're currently re-adding stuff we already removed some time ago.

I believe I've resolved this with 9781d2b, let me know if I missed anything