-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Do not commit generated files #983
base: main
Are you sure you want to change the base?
Conversation
This commit removes these generated files from the repository: - data/olm-catalog/ssp-operator.clusterserviceversion.yaml - data/crd/ssp.kubevirt.io_ssps.yaml Instead of these files, the csv-generator uses the generated "bundle" directory. Signed-off-by: Andrej Krejcir <[email protected]>
Quality Gate passedIssues Measures |
@akrejcir: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -52,4 +52,5 @@ USER 1000 | |||
|
|||
# Copy csv generator | |||
COPY --from=builder /workspace/bin/csv-generator . | |||
COPY bundle/manifests/ bundle/manifests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is not working well :(
error: build error: building at STEP "COPY bundle/manifests/ bundle/manifests/": checking on sources under "/tmp/build/inputs": copier: stat: "/bundle/manifests": no such file or directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The issue is that OCP CI builds the image simply using podman build Dockerfile
, so it does not call Makefile
to generate missing files.
Holding until I figure out how to change the build process, so that image can be build in the CI by /hold |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
What this PR does / why we need it:
This commit removes these generated files from the repository:
data/olm-catalog/ssp-operator.clusterserviceversion.yaml
data/crd/ssp.kubevirt.io_ssps.yaml
Instead of these files, the csv-generator uses the generated
bundle
directory.This change will be useful in the future when we update
operator-sdk
, because then the generated files will contain a creation timestamp, which would be updated in every new PR.Release note: