Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Do not commit generated files #983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Do not commit generated files #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,5 @@ USER 1000

# Copy csv generator
COPY --from=builder /workspace/bin/csv-generator .
COPY bundle/manifests/ bundle/manifests/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is not working well :(

error: build error: building at STEP "COPY bundle/manifests/ bundle/manifests/": checking on sources under "/tmp/build/inputs": copier: stat: "/bundle/manifests": no such file or directory

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The issue is that OCP CI builds the image simply using podman build Dockerfile, so it does not call Makefile to generate missing files.

ENTRYPOINT ["/manager"]
4 changes: 0 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,6 @@ generate: controller-gen
# Build the container image
.PHONY: container-build
container-build: unittest bundle
mkdir -p data/olm-catalog
mkdir -p data/crd
cp bundle/manifests/ssp-operator.clusterserviceversion.yaml data/olm-catalog/ssp-operator.clusterserviceversion.yaml
cp bundle/manifests/ssp.kubevirt.io_ssps.yaml data/crd/ssp.kubevirt.io_ssps.yaml
${SSP_BUILD_RUNTIME} build -t ${IMG} \
--build-arg IMG_REPOSITORY=${IMG_REPOSITORY} \
--build-arg IMG_TAG=${IMG_TAG} \
Expand Down
Loading