Remove unwraps from init() #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Mikayla <[email protected]>
|
Consider this a draft PR, as we need to make a similar change on other backends. |
kvark
approved these changes
Jun 11, 2024
Change code style in vulkan implementation to match other code Simplify the cross-backend errors
mikayla-maki
force-pushed
the
fallible-init
branch
from
a959409
to
33fd513
Compare
|
Assuming CI passes, this PR should be ready for review :) |
kvark
approved these changes
Jun 12, 2024
auto-merge was automatically disabled
June 14, 2024 22:30
Head branch was pushed to by a user without write access
mikayla-maki
pushed a commit
to zed-industries/zed
that referenced
this pull request
Jun 20, 2024
Based on the work on GLES support of @kvark, only two pieces were missing for usable GLES support: - kvark/blade#125 was upstreamed 2 weeks ago and is contained in the currently referenced zed-industries/blade fork - kvark/blade#126 was upstreamed 17 hours ago and is not contained in the zed-industries fork. As the zed-industries fork was also upstreamed in kvark/blade#128, we can switch back to mainline blade. If you don't want to switch back to mainline blade, please integrate kvark/blade#126 to your fork. Release Notes: - Fix GLES backend (#9581)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to present a sensible error message to users when we cannot
open a window.
Co-Authored-By: Mikayla [email protected]