Build wheels using the abi3 tag for sphericart-jax and sphericart-torch #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should reduce the number of wheels we need to build in #106 |
|
Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping |
Luthaf
force-pushed
the
abi3-wheels
branch
2 times, most recently
from
e7f21c8
to
93bcd70
Compare
|
Is this working? |
|
Not really: https://github.com/lab-cosmo/sphericart/actions/runs/7931040669/job/21654454335?pr=107 I think we need to pass a flag to pybind11 to use ABI3. The torch wheels I'm pretty confident are not directly linking to libpython, so they should be fine with just a |
Luthaf
force-pushed
the
abi3-wheels
branch
2 times, most recently
from
99e3921
to
5935419
Compare
3.29.0 does not work with Python 3.8
|
So this is not required for sphericart-torch (since we don't link to libpython directly) and is not supported by pybind11 for sphericart-jax. We'll have to find another way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python offers a stable ABI since version 3.2, which can be used to build wheels targetting some minimal Python version, and use it with all future Python versions, instead of building one wheel per Python version.
This should be the right thing to do for sphericart-jax where we are linking to Python.h ourself. I'll check that the wheel work and that we don't need to pass other flags to the compiler.
I'm not sure about sphericart-torch: since we are not actually linking to Python.h, we should be able to build a wheel compatible with any Python version (but a single PyTorch version).