[GH-798] - Configurator Game Modes #855
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvillegas98
commented
Aug 12, 2024
agustinesco
requested changes
Aug 13, 2024
apps/gateway/lib/gateway/controllers/curse_of_mirra/configuration_controller.ex
Outdated
Show resolved
Hide resolved
tvillegas98
force-pushed
the
gh-798-game-modes
branch
from
cf8b82f
to
77c5b01
Compare
agustinesco
reviewed
Aug 19, 2024
apps/configurator/lib/configurator_web/controllers/game_mode_html/index.html.heex
Show resolved
Hide resolved
AminArria
reviewed
Aug 22, 2024
|
|
||
| def change do | ||
| alter table(:game_modes) do | ||
| add :description, :text |
There was a problem hiding this comment.
Feel free to squash this into the other migration AddGameModesTable
There was a problem hiding this comment.
Whoops. Nice catch!
| use Ecto.Migration | ||
|
|
||
| def change do | ||
| create table(:game_modes) do |
There was a problem hiding this comment.
Why another table instead of an enum in versions? It feels like a lot of code/complexity to keep track of a string. Am I missing something?
There was a problem hiding this comment.
I see your point, but I think that marking a version as current in a game mode would be a bit more complex? What if we want to disabled a game mode? 🤔 .
That's a good idea to be honest, but I would to see if this fits our necessities or it is too much 😆
There was a problem hiding this comment.
How do you envision to that now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #798
Motivation
Add the game mode concept to the configurator. So we can group configurations below a game mode
DISCLAIMER: We're not addressing UI/UX concerns in this PR.
Summary of changes
How to test it?
UI/UX stills rough.
CONFIGURATOR_URL/game_modescreate a game modeCONFIGURATOR_URL/versionsand select a game modeChecklist