feat(python): support customize credential provider for write_dataset… #3283
Conversation
yanghua
force-pushed
the
3275-write_dataset_AwsCredentialsProvider
branch
2 times, most recently
from
ab24a5b to
b3219e8
Compare
| } | ||
|
|
||
| #[async_trait] | ||
| impl CredentialProvider for UrlBasedCredentialProvider { |
There was a problem hiding this comment.
Hi @eddyxu May I ask a question? I realized an UrlBasedCredentialProvider for our inner object store service to get a temporal credential via an assume role. It seems it is very similar to the AwsCredentialAdapter you have provided. Based on AwsCredentialAdapter, if I only need to implement the ProvideCredentials trait, that's enough for my purpose?
There was a problem hiding this comment.
Is there any way you can re-use the AwsCredentialsAdapter? Or is the purpose of this one somehow different?
There was a problem hiding this comment.
Actually, I need to implement a non-standard AssumeRoleProvider which receives a URL and fetches ak, sk and session_token from it and support TTL. The built-in AssumeRoleProvider can not customize a URL. It seems AwsCredentialAdapter provided a TTL-based credential wrapper. Maybe I need to implement ProvideCredentials trait.
yanghua
force-pushed
the
3275-write_dataset_AwsCredentialsProvider
branch
from
2653d0d to
596533b
Compare
… api in PyLance