Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add global counters for bytes_read & iops for benchmarking utility #3321

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

westonpace
Copy link
Contributor

This is a small change and not essential but has been useful for me for benchmarking and it might be nice to have it available.

@github-actions github-actions bot added enhancement New feature or request python labels Dec 31, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.02%. Comparing base (38a0a92) to head (b3fa19c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-io/src/scheduler.rs 25.00% 6 Missing ⚠️
rust/lance-core/src/datatypes.rs 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3321      +/-   ##
==========================================
+ Coverage   78.97%   79.02%   +0.05%     
==========================================
  Files         246      246              
  Lines       87628    87643      +15     
  Branches    87628    87643      +15     
==========================================
+ Hits        69202    69262      +60     
+ Misses      15558    15513      -45     
  Partials     2868     2868              
Flag Coverage Δ
unittests 79.02% <50.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit c0c1b53 into lancedb:main Jan 2, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants