Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reopening PR#5 #6

Open
wants to merge 85 commits into
base: main
Choose a base branch
from
Open

Reopening PR#5 #6

wants to merge 85 commits into from

Conversation

lbianchi-lbl
Copy link
Owner

No description provided.

@lbianchi-lbl
Update pip and "pip install" dependencies
eee414f
@lbianchi-lbl
Add trigger and prelim. check to support running tests on PR approval
abc7e76
@lbianchi-lbl
Use one of the test matrix instances to generate coverage report
137a479
@lbianchi-lbl
Remove branch name condition on PR trigger to make testing easier
326b24e
@lbianchi-lbl
Add missing matrix context in if condition
f6591eb
@lbianchi-lbl
Add more debug info to investigate false positive triggers
36adf52
@lbianchi-lbl
Display condition that should evaluate to false, but apparently doesn't
56343bb
@lbianchi-lbl
Try with if condition explicitly set to literal false
04b46ec
@lbianchi-lbl
Try if explicit expression syntax is needed for composite if conditions
4848eaa
@lbianchi-lbl
Another attempt since needs can interfere with job-level if
3275ada
@lbianchi-lbl
Try another attempt
325caa5
@lbianchi-lbl
One more attempt
4b24173
@lbianchi-lbl
Try if the explicit comparison to true works
9698ecb
@lbianchi-lbl
Check if using fromJSON makes a difference
7fc7398
@lbianchi-lbl
Temporarily disable PR workflow trigger for debugging
5170596
@lbianchi-lbl
Try with intermediate job with dependencies
09a8cdb
@lbianchi-lbl
Restore PR workflow trigger
1453d19 
Looks like the integration tests is not triggered on pull_request_review otherwise
@lbianchi-lbl
Address no steps defined error
2460456
@lbianchi-lbl
Try using outputs in intermediate job
8cb2bca
@lbianchi-lbl
Add syntax to evaluate expression in output
db8bb68
@lbianchi-lbl
Try comparing with string
d4256fb
@lbianchi-lbl
Add debug info
15b858a
@lbianchi-lbl
Use toJSON() for display
57d422c
@lbianchi-lbl
Try to see how needs output appears to following job
2625cc7
@lbianchi-lbl
Move check to step in intermediate job
bbac822
@lbianchi-lbl
Try if we can avoid having workflow status displayed as failure
7cb782c
@lbianchi-lbl
Revert to default to test if current version works for true positive
467d6c5
@lbianchi-lbl
Add more debug output
c80207d
@lbianchi-lbl
Try to get to the bottom of true || false evaluating to false
03e5228
@lbianchi-lbl
Commit to check if this triggers new reviews
5afe1da
idaes-debug
idaes-debug previously approved these changes Nov 26, 2020
View reviewed changes
@lbianchi-lbl lbianchi-lbl dismissed stale reviews from idaes-debug and fndari via e0f407b November 30, 2020 20:06
@fndari fndari self-requested a review November 30, 2020 20:49
fndari
fndari previously approved these changes Nov 30, 2020
View reviewed changes
@idaes-debug idaes-debug self-requested a review November 30, 2020 20:51
idaes-debug
idaes-debug previously approved these changes Nov 30, 2020
View reviewed changes
@lbianchi-lbl lbianchi-lbl dismissed stale reviews from idaes-debug and fndari via f9352d9 November 30, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idaes-build idaes-build idaes-build left review comments

@fndari fndari fndari left review comments

@idaes-debug idaes-debug Awaiting requested review from idaes-debug

At least 2 approving reviews are required to merge this pull request.

Assignees

@idaes-debug idaes-debug

Labels
added-by-bot ci:approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lbianchi-lbl @codecov-io @fndari @idaes-build @idaes-debug