Code

Reopening PR#5#6

Code

Open

lbianchi-lbl wants to merge 85 commits intomainlbianchi-lbl/idaes-pse:mainfrom integration-on-pr-approval-coveragelbianchi-lbl/idaes-pse:integration-on-pr-approval-coverageCopy head branch name to clipboard

+485-192

Commits

Commits on Nov 24, 2020

• Update pip and "pip install" dependencies

  lbianchi-lbl

  committed
  eee414f

  Copy full SHA for eee414f

• Add trigger and prelim. check to support running tests on PR approval

  lbianchi-lbl

  committed
  abc7e76

  Copy full SHA for abc7e76

• Use one of the test matrix instances to generate coverage report

  lbianchi-lbl

  committed
  137a479

  Copy full SHA for 137a479

• Remove branch name condition on PR trigger to make testing easier

  lbianchi-lbl

  committed
  326b24e

  Copy full SHA for 326b24e

• Add missing matrix context in if condition

  lbianchi-lbl

  committed
  f6591eb

  Copy full SHA for f6591eb

• Add more debug info to investigate false positive triggers

  lbianchi-lbl

  committed
  36adf52

  Copy full SHA for 36adf52

• Display condition that should evaluate to false, but apparently doesn't

  lbianchi-lbl

  committed
  56343bb

  Copy full SHA for 56343bb

• Try with if condition explicitly set to literal false

  lbianchi-lbl

  committed
  04b46ec

  Copy full SHA for 04b46ec

• Try if explicit expression syntax is needed for composite if conditions

  lbianchi-lbl

  committed
  4848eaa

  Copy full SHA for 4848eaa

• Another attempt since needs can interfere with job-level if

  lbianchi-lbl

  committed
  3275ada

  Copy full SHA for 3275ada

• Try another attempt

  lbianchi-lbl

  committed
  325caa5

  Copy full SHA for 325caa5

• One more attempt

  lbianchi-lbl

  committed
  4b24173

  Copy full SHA for 4b24173

• Try if the explicit comparison to true works

  lbianchi-lbl

  committed
  9698ecb

  Copy full SHA for 9698ecb

• Check if using fromJSON makes a difference

  lbianchi-lbl

  committed
  7fc7398

  Copy full SHA for 7fc7398

• Temporarily disable PR workflow trigger for debugging

  lbianchi-lbl

  committed
  5170596

  Copy full SHA for 5170596

• Try with intermediate job with dependencies

  lbianchi-lbl

  committed
  09a8cdb

  Copy full SHA for 09a8cdb

• Restore PR workflow trigger

  Show description for 1453d19
  lbianchi-lbl

  committed
  1453d19

  Copy full SHA for 1453d19

• Address no steps defined error

  lbianchi-lbl

  committed
  2460456

  Copy full SHA for 2460456

• Try using outputs in intermediate job

  lbianchi-lbl

  committed
  8cb2bca

  Copy full SHA for 8cb2bca

• Add syntax to evaluate expression in output

  lbianchi-lbl

  committed
  db8bb68

  Copy full SHA for db8bb68

• Try comparing with string

  lbianchi-lbl

  committed
  d4256fb

  Copy full SHA for d4256fb

• Add debug info

  lbianchi-lbl

  committed
  15b858a

  Copy full SHA for 15b858a

• Use toJSON() for display

  lbianchi-lbl

  committed
  57d422c

  Copy full SHA for 57d422c

• Try to see how needs output appears to following job

  lbianchi-lbl

  committed
  2625cc7

  Copy full SHA for 2625cc7

• Move check to step in intermediate job

  lbianchi-lbl

  committed
  bbac822

  Copy full SHA for bbac822

• Try if we can avoid having workflow status displayed as failure

  lbianchi-lbl

  committed
  7cb782c

  Copy full SHA for 7cb782c

• Revert to default to test if current version works for true positive

  lbianchi-lbl

  committed
  467d6c5

  Copy full SHA for 467d6c5

• Add more debug output

  lbianchi-lbl

  committed
  c80207d

  Copy full SHA for c80207d

• Try to get to the bottom of true || false evaluating to false

  lbianchi-lbl

  committed
  03e5228

  Copy full SHA for 03e5228

• Commit to check if this triggers new reviews

  lbianchi-lbl

  committed
  5afe1da

  Copy full SHA for 5afe1da

• Try evaluating trigger check decision from action script

  lbianchi-lbl

  committed
  552d3d6

  Copy full SHA for 552d3d6

• Add missing single quotes

  lbianchi-lbl

  committed
  c713043

  Copy full SHA for c713043

• Return script step result as string instead of JSON-encoded value

  lbianchi-lbl

  committed
  c09cf83

  Copy full SHA for c09cf83

• Improve debug info

  lbianchi-lbl

  committed
  af6bc7a

  Copy full SHA for af6bc7a

• Extract pip install commands to env variables shared by all jobs

  lbianchi-lbl

  committed
  1340647

  Copy full SHA for 1340647

• Try trigger when idaes-build is requested as reviewer

  lbianchi-lbl

  committed
  3458aa5

  Copy full SHA for 3458aa5

Commits on Nov 25, 2020

• Rename and add logging for clarity

  lbianchi-lbl

  committed
  3f266c6

  Copy full SHA for 3f266c6

• Use requested_reviewer field from event payload instead of PR object

  lbianchi-lbl

  committed
  212e53e

  Copy full SHA for 212e53e

• Use login field of reviewer directly

  lbianchi-lbl

  committed
  8402b2f

  Copy full SHA for 8402b2f

• Try single file with workflow trigger dispatch and common setup action

  lbianchi-lbl

  committed
  cb5a85d

  Copy full SHA for cb5a85d

• Remove spurious tick quote

  lbianchi-lbl

  committed
  98e46d0

  Copy full SHA for 98e46d0

• Fix issues with invalid action location and steps

  lbianchi-lbl

  committed
  a4b1982

  Copy full SHA for a4b1982

• Quote pytest marker

  lbianchi-lbl

  committed
  116f466

  Copy full SHA for 116f466

• Add back pull_request_review trigger

  lbianchi-lbl

  committed
  53ffb5e

  Copy full SHA for 53ffb5e

• Use less ambiguous name and encode verdict enum as JSON in workflow env

  lbianchi-lbl

  committed
  22faef1

  Copy full SHA for 22faef1

• Store choices in decide job output since env is not available in job if

  lbianchi-lbl

  committed
  4118e1d

  Copy full SHA for 4118e1d

• Get to the bottom of whether fromJSON is needed or not

  lbianchi-lbl

  committed
  59d2af7

  Copy full SHA for 59d2af7

• Use fromJSON in if condition since it's required to get an object

  lbianchi-lbl

  committed
  b9b1224

  Copy full SHA for b9b1224

• Try "fail fast" approach based on job dependencies to check what to run

  lbianchi-lbl

  committed
  25815e4

  Copy full SHA for 25815e4

• Remove incomplete job definition

  lbianchi-lbl

  committed
  2281a4c

  Copy full SHA for 2281a4c

• Fix wrong name

  lbianchi-lbl

  committed
  e413089

  Copy full SHA for e413089

• Use strings instead of arrays in if to address unexpected symbol errors

  lbianchi-lbl

  committed
  c31c7a6

  Copy full SHA for c31c7a6

• Remove object literal in if condition

  lbianchi-lbl

  committed
  b38b7d5

  Copy full SHA for b38b7d5

• Use context issue getter for guaranteed access to number property

  lbianchi-lbl

  committed
  e516664

  Copy full SHA for e516664

• Try simpler approach with integration checks running on PR review only

  lbianchi-lbl

  committed
  e8d574e

  Copy full SHA for e8d574e

• Rename approval to review for workflow running PR integration tests

  lbianchi-lbl

  committed
  462f78d

  Copy full SHA for 462f78d

• Add coverage report as separate job

  lbianchi-lbl

  committed
  aa86333

  Copy full SHA for aa86333

• Add workflow for checks on main and other protected branches

  lbianchi-lbl

  committed
  ac872c7

  Copy full SHA for ac872c7

• Extract pylint and docs build steps to local actions

  lbianchi-lbl

  committed
  af016d1

  Copy full SHA for af016d1

• Add comments for info about workflow triggers

  lbianchi-lbl

  committed
  e5dbf78

  Copy full SHA for e5dbf78

• Add debug output

  lbianchi-lbl

  committed
  f092f04

  Copy full SHA for f092f04

• Use correct name for requirements file

  lbianchi-lbl

  committed
  943cfb6

  Copy full SHA for 943cfb6

• Improve checks on submitted PR review for integration tests

  lbianchi-lbl

  committed
  f9262d8

  Copy full SHA for f9262d8

• Improve skip/run criteria and implementation

  lbianchi-lbl

  committed
  a92a819

  Copy full SHA for a92a819

• Use correct schema for review event

  lbianchi-lbl

  committed
  7fa3173

  Copy full SHA for 7fa3173

• Move all jobs with checks under PR workflow for checks to show up in PR

  lbianchi-lbl

  committed
  bc725f9

  Copy full SHA for bc725f9

• Split rapid/integration triggers to avoid shadowing running checks

  lbianchi-lbl

  committed
  b785670

  Copy full SHA for b785670

Commits on Nov 26, 2020

• Try using label to trigger integration tests from PR review

  lbianchi-lbl

  committed
  cde90b4

  Copy full SHA for cde90b4

• Use API to fetch list of reviews for PR

  lbianchi-lbl

  committed
  69b327f

  Copy full SHA for 69b327f

• Merge two steps in one to get around limitations in data/state sharing

  lbianchi-lbl

  committed
  3c5b0ed

  Copy full SHA for 3c5b0ed

• Convert functions in inline script to async

  lbianchi-lbl

  committed
  1056b55

  Copy full SHA for 1056b55

• Use await with async function

  lbianchi-lbl

  committed
  fb6651c

  Copy full SHA for fb6651c

• Refine algorithm for determining most recent review

  lbianchi-lbl

  committed
  7471a92

  Copy full SHA for 7471a92

• Add debug information for fetched reviews to detect pagination issues

  lbianchi-lbl

  committed
  fe76b10

  Copy full SHA for fe76b10

• Also run on review dismissal

  lbianchi-lbl

  committed
  a87993c

  Copy full SHA for a87993c

• Fix wrong quote

  lbianchi-lbl

  committed
  3149848

  Copy full SHA for 3149848

• Try pagination

  lbianchi-lbl

  committed
  21e2ef8

  Copy full SHA for 21e2ef8

• Try with async/await

  lbianchi-lbl

  committed
  3a3586d

  Copy full SHA for 3a3586d

Commits on Nov 30, 2020

• Try extracting trigger label name to workspace env context

  lbianchi-lbl

  committed
  e0f407b

  Copy full SHA for e0f407b

• Add error handling for missing labels

  lbianchi-lbl

  committed
  6cdf7d1

  Copy full SHA for 6cdf7d1

• Improve debug display

  lbianchi-lbl

  committed
  5e2d1d8

  Copy full SHA for 5e2d1d8

• Move if check since env context is only supported for step-level if

  lbianchi-lbl

  committed
  f9352d9

  Copy full SHA for f9352d9

• Move back check for label name since it must be done at the job level

  lbianchi-lbl

  committed
  24ff1ed

  Copy full SHA for 24ff1ed

• Fix minor typo

  lbianchi-lbl

  committed
  35071bf

  Copy full SHA for 35071bf

• Try more restrictive check for labeled event

  lbianchi-lbl

  committed
  0b215ef

  Copy full SHA for 0b215ef