Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: get rid of erws in Mathlib.Algebra.Group.InjSurj #17569

Closed
wants to merge 1 commit into from

Conversation

Vierkantor
Copy link
Contributor

@Vierkantor Vierkantor commented Oct 9, 2024

Almost all of the erws work just fine as rws. Only two places need additional rewriting: this is because the pow_succ' field of DivInvMonoids mentions Int.ofNat, which is not reducibly defeq to the actual cast we use in our lemmas.

This suggests we should redefine pow_succ' to use the actual cast instead: #17573.


Open in Gitpod

Almost all of the `erw`s are actually just `rw`s. Only two places need additional rewriting: this is because the `pow_succ'` field of `DivInvMonoid`s mentions `Int.ofNat`, which is not reducibly defeq to the actual cast we use in our lemmas.

This suggests we should redefine `pow_succ'` to use the actual cast instead.
@Vierkantor Vierkantor added the t-algebra Algebra (groups, rings, fields, etc) label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

PR summary 600253b2f0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@jcommelin
Copy link
Member

!bench

@jcommelin
Copy link
Member

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 9, 2024

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 600253b.
The entire run failed.
Found no significant differences.

@Vierkantor
Copy link
Contributor Author

Not sure why the linter is failing on the benchmark machine but the GitHub actions are passing. Are you happy to merge or do we want to debug this further first?

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 9, 2024
Almost all of the `erw`s work just fine as `rw`s. Only two places need additional rewriting: this is because the `pow_succ'` field of `DivInvMonoid`s mentions `Int.ofNat`, which is not reducibly defeq to the actual cast we use in our lemmas.

This suggests we should redefine `pow_succ'` to use the actual cast instead: #17573.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: get rid of erws in Mathlib.Algebra.Group.InjSurj [Merged by Bors] - chore: get rid of erws in Mathlib.Algebra.Group.InjSurj Oct 9, 2024
@mathlib-bors mathlib-bors bot closed this Oct 9, 2024
@mathlib-bors mathlib-bors bot deleted the un-erw-Group-InjSurj branch October 9, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants