[Merged by Bors] - chore: redefine DivInvMonoid.zpow_succ' field
#17573
+10
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary f82ab413baImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
|
Thanks 🎉 If CI passes, please remove the label bors d+ |
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
Almost all of the `erw`s work just fine as `rw`s. Only two places need additional rewriting: this is because the `pow_succ'` field of `DivInvMonoid`s mentions `Int.ofNat`, which is not reducibly defeq to the actual cast we use in our lemmas. This suggests we should redefine `pow_succ'` to use the actual cast instead: #17573.
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
leanprover-community-bot-assistant
added
the
merge-conflict
This field of the class refers to `Int.ofNat`, but this is not (reducibly) defeq to the coercion, and not `simp`-normal. By using the coercion instead, we get access to all the lemmas on the coercion. This means we should be able to get rid of a few `erw`s and `simp`s. An argument against this change is that the original version mirrors the definition of `Int` as an inductive type somewhat better. However, note that we already have a plain `0` in `zpow_zero'` instead of `Int.ofNat 0`.
Vierkantor
force-pushed
the
redefine-zpow_succ
branch
from
d2fc524
to
f82ab41
Compare
|
bors r+ |
|
👎 Rejected by label |
leanprover-community-bot-assistant
removed
the
merge-conflict
|
Come on, bors! bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
This field of the class refers to `Int.ofNat`, but this is not (reducibly) defeq to the coercion, and not `simp`-normal. By using the coercion instead, we get access to all the lemmas on the coercion. This means we should be able to get rid of a few `erw`s and `simp`s. We do the same for `SubNegMonoid.zsmul_succ'`. An argument against this change is that the original version mirrors the definition of `Int` as an inductive type somewhat better. However, note that we already have a plain `0` in `zpow_zero'` instead of `Int.ofNat 0`.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
DivInvMonoid.zpow_succ' fieldDivInvMonoid.zpow_succ' field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field of the class refers to
Int.ofNat, but this is not (reducibly) defeq to the coercion, and notsimp-normal. By using the coercion instead, we get access to all the lemmas on the coercion. This means we should be able to get rid of a fewerws andsimps.We do the same for
SubNegMonoid.zsmul_succ'.An argument against this change is that the original version mirrors the definition of
Intas an inductive type somewhat better. However, note that we already have a plain0inzpow_zero'instead ofInt.ofNat 0.erws in Mathlib.Algebra.Group.InjSurj #17569