Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font subsetting and translated message files for release-v0.17.x #12445

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Updates translations and font subsetting for release

Reviewer guidance

I did a close spot check on Arabic, and didn't see any messages getting incorrectly deleted.
Did a quick review of other languages to ensure the number of files and changes was mostly consistent across languages.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: renderers HTML5 apps, videos, exercises, etc. APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Jul 15, 2024
@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Jul 16, 2024
@radinamatic
Copy link
Member

All locales plus the new Punjabi are now a-Ok!

1 2
2024-07-16_02-35-40 2024-07-16_03-14-27

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏽 👏🏽 :shipit:

@rtibbles rtibbles merged commit 846b97f into learningequality:release-v0.17.x Jul 16, 2024
33 checks passed
@rtibbles rtibbles deleted the translations branch July 16, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: backend Python, databases, networking, filesystem... DEV: frontend DEV: renderers HTML5 apps, videos, exercises, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants