ran Cargo outdated #178
Merged
ran Cargo outdated #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running "cargo doc" gives this warning
warning: unknown lint: `clippy::needless_pass_by_ref_mut`
--> src/service/reload.rs:104:9
|
104 | #[allow(clippy::needless_pass_by_ref_mut)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::needless_pass_by_value`
|
= note: `#[warn(unknown_lints)]` on by default
warning: `cargo-leptos` (lib) generated 1 warning
The name "needless_pass_by_ref_mut" was not wrong at the time of writing, it is just stale
https://rust-lang.github.io/rust-clippy/master/index.html#/clippy::needless_pass_by_ref_mut
Additionally this "allow" is no longer needed to get cargo clippy to "pass" as of
cargo clippy --version
clippy 0.1.71 (8ede3aa 2023-07-12)
I have trimmed down the list by using the modern versions of a couple of packges. it a long list ... and can be completely cleared because of this Cargo.toml # not using notify 5.0 because it uses Crossbeam which has an issue with tokio notify = "4.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ran cargo outdated
I have trimmed down the list by using the modern versions of a couple of packges.
it a long list ... and can be completely cleared because of this
Cargo.toml
-- not using notify 5.0 because it uses Crossbeam which has an issue with tokio
notify = "4.0"