Generate large benchmark files for nightly benchmarks #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only generate the "large" benchmark files for the Criterion benchmarks in our 'bench' CI job, because that is when they are needed. However, with commit 9d1978e ("Add benchmark for ELF "str2symtab" creation") it now one of the earlier nightly benchmarks that already requires one of those files. Thus, make sure to generate them just a bit earlier. Signed-off-by: Daniel Müller <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
==========================================
+ Coverage 94.47% 94.59% +0.12%
==========================================
Files 57 57
Lines 10644 10644
==========================================
+ Hits 10056 10069 +13
+ Misses 588 575 -13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only generate the "large" benchmark files for the Criterion benchmarks in our 'bench' CI job, because that is when they are needed. However, with commit 9d1978e ("Add benchmark for ELF "str2symtab" creation") it now one of the earlier nightly benchmarks that already requires one of those files.
Thus, make sure to generate them just a bit earlier.