fix: return closest peers from FIND_NODE #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `FIND_NODE` DHT operation should return the closest peers the node knows to the value. It does not need to return itself in the list because the calling peer already knows about it. Fixes #2450
|
Looks good, thanks @achingbrain ! |
maschad
approved these changes
Apr 23, 2024
| @@ -799,6 +799,37 @@ describe('KadDHT', () => { | |||
|
|
|||
| expect(res).to.not.be.empty() | |||
| }) | |||
|
|
|||
| it('should not include itself in getClosestPeers PEER_RESPONSE', async function () { | |||
| this.timeout(240 * 1000) | |||
There was a problem hiding this comment.
Just curious, why are we using a 240 second timeout?
There was a problem hiding this comment.
No specific reason, it was copied from the preceding test.
Co-authored-by: Chad Nehemiah <[email protected]>
Merged
achingbrain
added a commit
that referenced
this pull request
Apr 29, 2024
Partial revert of #2499 If a node is queried for it's own peer id, return it's own peer info. This is necessary because since libp2p/go-libp2p-kad-dht#820 go-libp2p-kad-dht won't add a peer to it's routing tables that doesn't have any DHT peers that are KAD-futher from it's own ID already.
3 tasks
achingbrain
added a commit
that referenced
this pull request
Apr 29, 2024
Partial revert of #2499 If a node is queried for it's own peer id, return it's own peer info. This is necessary because since libp2p/go-libp2p-kad-dht#820 go-libp2p-kad-dht won't add a peer to it's routing tables that doesn't have any DHT peers that are KAD-futher from it's own ID already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FIND_NODEDHT operation should return the closest peers the node knows to the value.It does not need to return itself in the list because the calling peer already knows about it.
Fixes #2450
Change checklist