Change XDelta support to automatic and check lzma.h presence. #15962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add support for Android for xdelta too, since now it will fail without the headers on build and there is another pr that also added support for iOS? I believe the original pr doesn't from not touching the android makefile. |
|
Ok... I need to clarify, I don't know if the older commit doesn't run on android (I can't build), but I suspect so, because all the other xdelta commits activated the feature manually on the platform makefiles, but the android makefile wasn't touched (it's I think, but not sure) at https://github.com/libretro/RetroArch/tree/master/pkg/android So asking me if it fixes the issue is useless, I can't test. |
|
(Just to make it clear, I am not planning to add XDelta setting to Android within this PR.) |
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On some platforms, compilation can fail if lzma.h is not present, better check if it is really available.
This modification will disable XDelta support if lzma.h can not be found, and fails ./configure if --enable-xdelta was given.
Related Pull Requests
#15915