Fix the build when XDelta is enabled on certain platforms #15968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- zlib defines its own macro by that name, but with a different value
|
I'd like to be sure that this fixes the issue on Android before merging this. |
|
LGTM. |
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
…5968) * Rename the `MIN_MATCH` defined by xdelta3 to `XD3_MIN_MATCH` - zlib defines its own macro by that name, but with a different value * Don't redefine `SIZEOF_ARRAY` in xdelta3 if it already exists * Don't define ssize_t in xdelta3, rely on libretro's definition instead * Enable xdelta3 support in MSVC 2015-2019 * Fix some invalid MSBuild condition syntax * Always build xdelta with XD3_USE_LARGESIZET as 1 * Fix an `#if` in task_patch.c * Enable `HAVE_XDELTA` in the UWP build * First crack at fixing Xdelta support for Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the build on some platforms when XDelta3 support is enabled.
Related Issues
Maybe #15963, I don't know yet. I'll follow up and ask the reporter to test this PR.
Related Pull Requests
This comment says that Android won't build with XDelta3 support enabled. I don't know if this PR fixes that issue; I'd like to see if #15962 does, first.
Reviewers
@LibretroAdmin