[POC] TF-2955 Reduce time in opening tmail app #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/2959. |
| } | ||
|
|
||
| void getSessionAction() { | ||
| void getSessionAction({PersonalAccount? personalAccount}) { |
There was a problem hiding this comment.
Unused PersonalAccount param, consider remove
Comment on lines
+25
to
+27
| bool isResynchronized = false; | ||
| bool isShowingWarningDialogSessionExpired = false; | ||
| bool isShowingWarningDialogResynchronizeSessionFailure = false; |
There was a problem hiding this comment.
Should these bool be replaced by enum?
Comment on lines
+519
to
+520
| if (apiUrl.isNotEmpty) { | ||
| updateAuthenticationAccount( |
There was a problem hiding this comment.
To avoid checking apiUrl.isNotEmpty in multiple location, should we move this if check inside updateAuthenticationAccount?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2955
Solution
Demo
Synchronize session successdemo-success.mov
Synchronize session failuredemo-failure.mov
Resynchronize session failureScreen.Recording.2024-06-25.at.11.53.04.online-video-cutter.com.mp4