-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] TF-2955 Reduce time in opening tmail app #2959
Open
dab246
wants to merge
6
commits into
refactor
Choose a base branch
from
improvement/tf-2955-reduce-time-in-opening-tmail-app
base: refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
54b13f6
TF-2955 Add GetSessionCacheInteractor
dab246 6b8644b
TF-2955 Implement get session cache when reopen app on mobile
dab246 8b96391
TF-2955 Add SynchronizeLatestSessionInteractor
dab246 ddae070
TF-2955 Implement session synchronization when the application is int…
dab246 ad4077d
TF-2955 Show warning dialog synchronize session failure
dab246 e666b06
TF-2955 Handle click on notification in android when app terminated
dab246 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import 'package:core/presentation/state/failure.dart'; | ||
| import 'package:core/presentation/state/success.dart'; | ||
| import 'package:dartz/dartz.dart'; | ||
| import 'package:get/get.dart'; | ||
| import 'package:tmail_ui_user/features/base/mixin/message_dialog_action_mixin.dart'; | ||
| import 'package:tmail_ui_user/features/base/mixin/popup_context_menu_action_mixin.dart'; | ||
|
|
||
| abstract class ConsumeViewStateUIController extends GetxController | ||
| with MessageDialogActionMixin, PopupContextMenuActionMixin { | ||
|
|
||
| final viewState = Rx<Either<Failure, Success>>(Right(UIState.idle)); | ||
|
|
||
| void consumeState(Stream<Either<Failure, Success>> newStateStream) { | ||
| newStateStream.listen(onData, onError: onError, onDone: onDone); | ||
| } | ||
|
|
||
| void dispatchState(Either<Failure, Success> newState) { | ||
| viewState.value = newState; | ||
| } | ||
|
|
||
| void clearState() { | ||
| viewState.value = Right(UIState.idle); | ||
| } | ||
|
|
||
| void onData(Either<Failure, Success> newState) { | ||
| viewState.value = newState; | ||
| viewState.value.fold(handleFailureViewState, handleSuccessViewState); | ||
| } | ||
|
|
||
| void onError(Object error, StackTrace stackTrace) {} | ||
|
|
||
| void onDone() {} | ||
|
|
||
| void handleFailureViewState(Failure failure); | ||
|
|
||
| void handleSuccessViewState(Success success); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
lib/features/home/domain/state/get_session_cache_state.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import 'package:core/presentation/state/failure.dart'; | ||
| import 'package:core/presentation/state/success.dart'; | ||
| import 'package:jmap_dart_client/jmap/core/session/session.dart'; | ||
| import 'package:model/account/personal_account.dart'; | ||
|
|
||
| class GetSessionCacheLoading extends LoadingState {} | ||
|
|
||
| class GetSessionCacheSuccess extends UIState { | ||
| final Session session; | ||
| final PersonalAccount personalAccount; | ||
|
|
||
| GetSessionCacheSuccess({ | ||
| required this.session, | ||
| required this.personalAccount | ||
| }); | ||
|
|
||
| @override | ||
| List<Object?> get props => [session]; | ||
| } | ||
|
|
||
| class GetSessionCacheFailure extends FeatureFailure { | ||
| final PersonalAccount personalAccount; | ||
|
|
||
| GetSessionCacheFailure({ | ||
| required this.personalAccount, | ||
| dynamic exception | ||
| }) : super(exception: exception); | ||
|
|
||
| @override | ||
| List<Object?> get props => [personalAccount, ...super.props]; | ||
| } |
26 changes: 26 additions & 0 deletions
26
lib/features/home/domain/usecases/get_session_cache_interactor.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import 'package:core/presentation/state/failure.dart'; | ||
| import 'package:core/presentation/state/success.dart'; | ||
| import 'package:dartz/dartz.dart'; | ||
| import 'package:model/account/personal_account.dart'; | ||
| import 'package:tmail_ui_user/features/home/domain/repository/session_repository.dart'; | ||
| import 'package:tmail_ui_user/features/home/domain/state/get_session_cache_state.dart'; | ||
|
|
||
| class GetSessionCacheInteractor { | ||
| final SessionRepository _sessionRepository; | ||
|
|
||
| GetSessionCacheInteractor(this._sessionRepository); | ||
|
|
||
| Stream<Either<Failure, Success>> execute(PersonalAccount personalAccount) async* { | ||
| try { | ||
| yield Right<Failure, Success>(GetSessionCacheLoading()); | ||
| final sessionCache = await _sessionRepository.getStoredSession(); | ||
| yield Right<Failure, Success>(GetSessionCacheSuccess( | ||
| session: sessionCache, | ||
| personalAccount: personalAccount)); | ||
| } catch (e) { | ||
| yield Left<Failure, Success>(GetSessionCacheFailure( | ||
| personalAccount: personalAccount, | ||
| exception: e)); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused
PersonalAccountparam, consider remove