Add correct list of dependency packages for perftest #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2024 15:27
During the RPM package build process for perftest, libraries are added and we cannot specify dependencies when we have the package. This patch addresses the issue by adding only the minimum necessary packages that include those libraries, considering recursion. After applying this patch, installing the package with its dependencies will work successfully.
Perftest requires the rdma-core and libibumad packages for proper operation, but they are missing from the dependency list. As a result, perftest can be installed successfully, and its tools can be used, but some will not work without the libibumad package. This patch adds the missing dependencies to the perftest package.
tzafrir-mellanox
suggested changes
Jan 5, 2025
| @@ -10,7 +10,7 @@ Vcs-Browser: http://git.openfabrics.org/git?p=~shamoya/perftest.git;a=summary | |||
|
|
|||
| Package: perftest | |||
| Architecture: any | |||
| Depends: ${shlibs:Depends}, ${misc:Depends}, libibverbs1 (>= 1.1.6), librdmacm1 (>=1.0.8) | |||
| Depends: ${shlibs:Depends}, ${misc:Depends}, libibverbs1 (>= 1.1.6), librdmacm1 (>=1.0.8), libibumad, rdma-core | |||
There was a problem hiding this comment.
Dependencies on libraries are added automatically at build time. For instance, the deb package depends on libibumad3 as well as on some other rdma-core libraries (libibverbs1, and others). See https://packages.debian.org/sid/perftest .
Why doe sit need to depend on rdma-core?
| @@ -9,6 +9,7 @@ Url: http://www.openfabrics.org | |||
| BuildRoot: %{_tmppath}/%{name}-%{version}-build | |||
| BuildRequires: libibverbs-devel librdmacm-devel libibumad-devel | |||
| BuildRequires: pciutils-devel | |||
| Requires: libibverbs libibumad librdmacm libpci3 rdma-core | |||
There was a problem hiding this comment.
See other comment: dependencies on libraries should be auto-generated. Dependency on rdma-core: why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating .deb and .rpm packages for perftest, some dependencies for proper operation are missing. This patch adds the correct list of minimum required packages that include all the necessary libraries for perftest to function successfully.
For rpm package was added the following list of dependencies
For deb package was added
libibumadandrdma-core, which were missing.